WINDUPRULE-394: Spring boot version support rule #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-brophy
changed the title
|
retest |
mrizzi
reviewed
Oct 21, 2019
There was a problem hiding this comment.
Other than the comments in the code, some more issues:
springboot.rhamt.xmlshould be moved intorules-reviewed/rhr/springboot/path- remove
spring-boot-admin-sample-war-1.2.4.war - add
spring-boot-sample.war(added into JIRA) intorules-reviewed/rhr/springboot/tests/data/path for tests
Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
|
Changes applied |
mrizzi
reviewed
Oct 22, 2019
There was a problem hiding this comment.
I figured out that the right name it's "Spring Boot", 2 words, so i added some comments to fix it together with one for fixing the test.
Other than this, i think we could enhance the approach dividing the current rule into 2 rules (same and current groupId and artifactId values for both):
- a rule that searches with
toVersion=1(no matter the minor) without afromVersion- effort = 3
- category-id = mandatory
- message =
Spring Boot has to be updated to Spring Boot 2.0 before being able to be migrated to a version supported by Red Hat Runtimes - link = keep the 2 links we already have and add one further with
title=Spring Boot 2.0 Migration Guideandhrefhttps://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.0-Migration-Guide
- a rule that searches with
fromVersion=2.0andtoVersion=2.1.1.RELEASE- effort = 1
- category-id = potential
- message =
Spring Boot has to be updated to a version supported by Red Hat Runtimes - link = keep the 2 links we already have and add one further with
title=Spring Boot 2.1 - Upgrading from Spring Boot 2.0andhrefhttps://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.1-Release-Notes#upgrading-from-spring-boot-20
Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
Co-Authored-By: Marco Rizzi <mrizzi@users.noreply.github.com>
…different versions
…different versions
…different versions
…different versions
|
Successfully tested using applications with Spring 1.3.0 version artifacts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on PR windup/windup#1364