Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUPRULE-394: Spring boot version support rule #378

Merged
merged 23 commits into from
Oct 23, 2019
Merged

WINDUPRULE-394: Spring boot version support rule #378

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
598390d
spring boot version rhoar support rule
m-brophy Oct 17, 2019
96d679f
spring boot version rhoar support rule
m-brophy Oct 17, 2019
ef47122
WINDUPRULE-394: spring boot version rhoar support rule
m-brophy Oct 17, 2019
33f29bf
WINDUPRULE-394: spring boot version rhoar support rule
m-brophy Oct 21, 2019
e1e2c21
Update rules-reviewed/springboot/springboot.rhamt.xml
m-brophy Oct 21, 2019
1825d82
Update rules-reviewed/springboot/springboot.rhamt.xml
m-brophy Oct 21, 2019
703c2d1
Update rules-reviewed/springboot/springboot.rhamt.xml
m-brophy Oct 21, 2019
a49595e
Update rules-reviewed/springboot/springboot.rhamt.xml
m-brophy Oct 21, 2019
7e0086c
Update rules-reviewed/springboot/springboot.rhamt.xml
m-brophy Oct 21, 2019
b3fd28e
Update rules-reviewed/springboot/springboot.rhamt.xml
m-brophy Oct 21, 2019
ba3429e
Update rules-reviewed/springboot/springboot.rhamt.xml
m-brophy Oct 21, 2019
3b18661
WINDUPRULE-394: spring boot version rhoar support rule
m-brophy Oct 22, 2019
f299462
WINDUPRULE-394: spring boot version rhr support rule refactored to rh…
m-brophy Oct 22, 2019
e524835
WINDUPRULE-394: spring boot version rhr support rule iterable filter …
m-brophy Oct 22, 2019
889ead0
Update rules-reviewed/rhr/springboot/springboot.rhamt.xml
m-brophy Oct 22, 2019
f0c8525
Update rules-reviewed/rhr/springboot/springboot.rhamt.xml
m-brophy Oct 22, 2019
6e850b7
Update rules-reviewed/rhr/springboot/springboot.rhamt.xml
m-brophy Oct 22, 2019
aac9fa2
WINDUPRULE-394: spring boot version rhr support rule, split rule for …
m-brophy Oct 22, 2019
18b2446
WINDUPRULE-394: spring boot version rhr support rule, split rule for …
m-brophy Oct 22, 2019
8668cfa
WINDUPRULE-394: spring boot version rhr support rule, split rule for …
m-brophy Oct 22, 2019
839c9b5
WINDUPRULE-394 Changed 'user.home' property to have archive-metadata …
mrizzi Oct 23, 2019
ad14e01
WINDUPRULE-394: spring boot version rhr support rule, split rule for …
m-brophy Oct 23, 2019
1aa18a8
WINDUPRULE-394: spring boot version rhr support rule, fix local tests
m-brophy Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 33 additions & 0 deletions rules-reviewed/springboot/springboot.rhamt.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?xml version="1.0"?>
<ruleset id="ocp-001" xmlns="http://windup.jboss.org/schema/jboss-ruleset"
m-brophy marked this conversation as resolved.
Show resolved Hide resolved
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd">
<metadata>
<description>
Verify the version of the Springboot application is compatible with those supported by RHOAR
m-brophy marked this conversation as resolved.
Show resolved Hide resolved
</description>
<!-- version ranges applied to from and to technologies -->
<dependencies>
<addon id="org.jboss.windup.rules,windup-rules-javaee,3.0.0.Final" />
<addon id="org.jboss.windup.rules,windup-rules-java,3.0.0.Final" />
<addon id="org.jboss.windup.rules,windup-rules-xml,3.0.0.Final" />
</dependencies>
m-brophy marked this conversation as resolved.
Show resolved Hide resolved
<targetTechnology id="cloud-readiness"/>
m-brophy marked this conversation as resolved.
Show resolved Hide resolved
</metadata>
<rules>
<rule id="ocp-001-00001">
m-brophy marked this conversation as resolved.
Show resolved Hide resolved
<!-- rule condition, when it could be fired -->
<when>
<dependency groupId="org.springframework.boot" artifactId="{*}" fromVersion="1.0.0.RELEASE" toVersion="2.1.1.RELEASE" />
</when>
<!-- rule operation, what to do if it is fired -->
<perform>
<hint title="ocp-001-00001 Unsupported version of SpringBoot" effort="1"
category-id="potential">
<message><![CDATA[ocp-001-00001 Unsupported version of SpringBoot ]]></message>
m-brophy marked this conversation as resolved.
Show resolved Hide resolved
<link href="https://access.redhat.com/articles/3348731" title="RHOAR SpringBoot Supported Configurations">link</link>
m-brophy marked this conversation as resolved.
Show resolved Hide resolved
</hint>
</perform>
</rule>
</rules>
</ruleset>
Binary file added rules-reviewed/springboot/tests/data/spring-boot-admin-sample-war-1.2.4.war
View file
Open in desktop
Binary file not shown.
21 changes: 21 additions & 0 deletions rules-reviewed/springboot/tests/springboot.rhamt.test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<?xml version="1.0"?>
<ruletest id="ocp-001-test"
m-brophy marked this conversation as resolved.
Show resolved Hide resolved
xmlns="http://windup.jboss.org/schema/jboss-ruleset"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd">
<testDataPath>data</testDataPath>
<rulePath>../springboot.rhamt.xml</rulePath>
<ruleset>
<rules>
<rule id="ocp-001-00001-test">
<when>
<not>
<hint-exists message="Unsupported version of spring-boot-starter-logging"/>
m-brophy marked this conversation as resolved.
Show resolved Hide resolved
</not>
</when>
<perform>
<fail message="[springboot-001] Spring Boot hint was not found!" />
</perform>
</rule>
</rules>
</ruleset>
</ruletest>