[WINDUPRULE-432,433,435,436,437,438] - camel components moved out of camel-core #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
test this please |
mmelko
changed the title
mmelko
force-pushed
the
WINDUPRULE-437-camel-rest-moved
branch
from
ffd775f
to
425cf9e
Compare
mmelko
changed the title
mmelko
changed the title
|
retest |
|
add to whitelist |
|
Please remove label "Depend on another PR". PR is already merged to master. |
m-brophy
requested changes
Feb 25, 2020
| </not> | ||
| </when> | ||
| <perform> | ||
| <fail message="[xml-moved-components] camel-rest dependency moved hint was not found!"/> |
There was a problem hiding this comment.
Suggested change
| <fail message="[xml-moved-components] camel-rest dependency moved hint was not found!"/> | |
| <fail message="[xml-moved-components] camel-attachments dependency moved hint was not found!"/> |
| </not> | ||
| </when> | ||
| <perform> | ||
| <fail message="[xml-moved-components] camel-rest dependency moved hint was not found!"/> |
There was a problem hiding this comment.
Suggested change
| <fail message="[xml-moved-components] camel-rest dependency moved hint was not found!"/> | |
| <fail message="[xml-moved-components] camel-dataformat dependency moved hint was not found!"/> |
| </not> | ||
| </when> | ||
| <perform> | ||
| <fail message="[xml-moved-components] `camel-zip-deflater` dependency moved hint was not found!"/> |
There was a problem hiding this comment.
Suggested change
| <fail message="[xml-moved-components] `camel-zip-deflater` dependency moved hint was not found!"/> | |
| <fail message="[xml-moved-components] `camel-xpath` dependency moved hint was not found!"/> |
| <iteration over="dependencies-block"> | ||
| <hint title="`camel-zip-deflater` component has been moved" effort="1" category-id="mandatory"> | ||
| <message>`camel-zip-deflater` dependency required. Component has been moved from `camel-core` to separate artifact | ||
| org.apache.camel:camel-dataformat that has to be added as a dependency to your project pom.xml file |
There was a problem hiding this comment.
Suggested change
| org.apache.camel:camel-dataformat that has to be added as a dependency to your project pom.xml file | |
| org.apache.camel:camel-zip-deflater that has to be added as a dependency to your project pom.xml file |
| <iteration over="dependencies-block"> | ||
| <hint title="`camel-zip-deflater` component has been moved" effort="1" category-id="mandatory"> | ||
| <message>`camel-zip-deflater` dependency required. Component has been moved from `camel-core` to separate artifact | ||
| org.apache.camel:camel-dataformat that has to be |
There was a problem hiding this comment.
Suggested change
| org.apache.camel:camel-dataformat that has to be | |
| org.apache.camel:camel-zip-deflator that has to be |
| <iteration over="dependencies-block"> | ||
| <hint title="`camel-xpath` component has been moved" effort="1" category-id="mandatory"> | ||
| <message>`camel-xpath` dependency required. Component has been moved from `camel-core` to separate artifact | ||
| org.apache.camel:camel-dataformat that has to be added as a dependency to your project pom.xml file |
There was a problem hiding this comment.
Suggested change
| org.apache.camel:camel-dataformat that has to be added as a dependency to your project pom.xml file | |
| org.apache.camel:camel-xpath that has to be added as a dependency to your project pom.xml file |
mmelko
force-pushed
the
WINDUPRULE-437-camel-rest-moved
branch
from
425cf9e
to
559d9e3
Compare
|
@m-brophy thanks for the review. All changes should be included now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WINDUPRULE-432 -
camel-zip-deflaterhttps://issues.redhat.com/browse/WINDUPRULE-433
camel-attachementshttps://issues.redhat.com/browse/WINDUPRULE-435
camel-dataformathttps://issues.redhat.com/browse/WINDUPRULE-436
camel-languagehttps://issues.redhat.com/browse/WINDUPRULE-437
camel-resthttps://issues.redhat.com/browse/WINDUPRULE-438
camel-xpath