Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WINDUPRULE-440,443,444,446,447,448,450,451,452,453,454,455,456] Add rules for java generic information chapter #409

Merged
merged 23 commits into from Mar 4, 2020

Conversation

@mmelko
Copy link
Contributor Author

mmelko commented Feb 21, 2020

This PR depends on #401 due to 7e3c5a0 that's adding rule also into xml-moved-components.windup.xml

@m-brophy
Copy link
Contributor

m-brophy commented Mar 3, 2020

java-generic-information.windup.xml:47

<replacement>org.apache.camel.impl.{SupportClass}</replacement>

Should be

<replacement>org.apache.camel.support.{SupportClass}</replacement>

I realise this change wasn't made in this PR....

</message>
<link title="Camel 3 - Migration Guide: Generic Information"
href="https://camel.apache.org/manual/latest/camel-3-migration-guide.html#_generic_information"/>
<quickfix type="REPLACE" name="AggregationStrategy-replace">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate quickfix name -

Suggested change
<quickfix type="REPLACE" name="AggregationStrategy-replace">
<quickfix type="REPLACE" name="Support-replace2">

</message>
<link title="Camel 3 - Migration Guide: Generic Information"
href="https://camel.apache.org/manual/latest/camel-3-migration-guide.html#_generic_information"/>
<quickfix type="REPLACE" name="AggregationStrategy-replace">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<quickfix type="REPLACE" name="AggregationStrategy-replace">
<quickfix type="REPLACE" name="Registry-replace">

</message>
<link title="Camel 3 - Migration Guide: Generic Information"
href="https://camel.apache.org/manual/latest/camel-3-migration-guide.html#_generic_information"/>
<quickfix type="REPLACE" name="AggregationStrategy-replace">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<quickfix type="REPLACE" name="AggregationStrategy-replace">
<quickfix type="REPLACE" name="LoadBalancer-replace">

<message>The class `org.apache.camel.impl.{moved}` has been moved to `org.apache.camel.impl.engine` package.</message>
<link title="Camel 3 - Migration Guide: Generic Information"
href="https://camel.apache.org/manual/latest/camel-3-migration-guide.html#_generic_information"/>
<quickfix type="REPLACE" name="AggregationStrategy-replace">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<quickfix type="REPLACE" name="AggregationStrategy-replace">
<quickfix type="REPLACE" name="camel.impl-replace">

</message>
<link title="Camel 3 - Migration Guide: Generic Information"
href="https://camel.apache.org/manual/latest/camel-3-migration-guide.html#_generic_information"/>
<quickfix type="REPLACE" name="AggregationStrategy-replace">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<quickfix type="REPLACE" name="AggregationStrategy-replace">
<quickfix type="REPLACE" name="AggregationStrategies-replace">

<message>Class `org.apache.camel.builder.xml.XPathBuilder` has been moved to `org.apache.camel.language.xpath.XPathBuilder`.</message>
<link href="https://camel.apache.org/manual/latest/camel-3-migration-guide.html#_generic_information"
title="Camel 3 - Migration Guide"/>
<quickfix type="REPLACE" name="Annotation-replace">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<quickfix type="REPLACE" name="Annotation-replace">
<quickfix type="REPLACE" name="XPathBuilder-Annotation-replace">

<message>Annotation `org.apache.camel.language.XPath` has been moved to `org.apache.camel.language.xpath.XPath`</message>
<link href="https://camel.apache.org/manual/latest/camel-3-migration-guide.html#_generic_information"
title="Camel 3 - Migration Guide"/>
<quickfix type="REPLACE" name="Annotation-replace">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<quickfix type="REPLACE" name="Annotation-replace">
<quickfix type="REPLACE" name="XPath-Annotation-replace">

<message>Exception `org.apache.camel.builder.xml.InvalidXPathExpression` has been moved to `org.apache.camel.language.xpath.InvalidXPathException `</message>
<link href="https://camel.apache.org/manual/latest/camel-3-migration-guide.html#_generic_information"
title="Camel 3 - Migration Guide"/>
<quickfix type="REPLACE" name="Annotation-replace">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<quickfix type="REPLACE" name="Annotation-replace">
<quickfix type="REPLACE" name="InvalidXPathExpression-Annotation-replace">

<message>Exception `org.apache.camel.processor.validation.PredicateValidationException` has been moved to `org.apache.camel.support.processor.validation.PredicateValidationException`</message>
<link href="https://camel.apache.org/manual/latest/camel-3-migration-guide.html#_generic_information"
title="Camel 3 - Migration Guide"/>
<quickfix type="REPLACE" name="Annotation-replace">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<quickfix type="REPLACE" name="Annotation-replace">
<quickfix type="REPLACE" name="PredicateValidationException-Annotation-replace">

</or>
</when>
<perform>
<iteration over="dependencies-block">
<hint title="`camel-dataformat` component has been moved" effort="1" category-id="mandatory">
<message>`camel-dataformat` dependency required. Component has been moved from `camel-core` to separate artifact
org.apache.camel:camel-dataformat that has to be added as a dependency to your project pom.xml file
org.apache.camel:camel-dataformat that has to be added as a dependency to your projectom.xml file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a typo

mmelko pushed a commit to mmelko/windup-rulesets that referenced this pull request Mar 4, 2020
mmelko pushed a commit to mmelko/windup-rulesets that referenced this pull request Mar 4, 2020
@mmelko mmelko force-pushed the camel-java-generic-information branch from 8c61192 to c3082cd Compare March 4, 2020 13:05
mmelko added a commit to mmelko/windup-rulesets that referenced this pull request Mar 4, 2020
@mmelko mmelko force-pushed the camel-java-generic-information branch from c3082cd to c7b37dd Compare March 4, 2020 13:09
@mmelko mmelko force-pushed the camel-java-generic-information branch from c7b37dd to ca43a94 Compare March 4, 2020 13:19
@mmelko mmelko requested a review from m-brophy March 4, 2020 13:20
Copy link
Contributor

@m-brophy m-brophy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changes @mmelko

@m-brophy m-brophy merged commit bcb1b2e into windup:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants