Winduprule 476 spring metrics quarkus #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 27, 2020 09:30
…he technology tag
|
retest |
|
@jonathanvila - The rules worked fine. Nice to see the new Micrometer (embedded) Technology tag on the Application List. The issues are nicely worded and the links work fine and are appropriate. I was a little surprised that the test data was jar file rather than just source files. The tests took a long time to run due to the decompilation effort. Also I was wondering about whether these rules would lend themselves to quickfixes? Thanks. |
added 6 commits
April 16, 2020 14:19
removed dependency between rules
jonathanvila
added
Ready to Review
and removed
Work in Progress/For Discussion Only
labels
added 3 commits
April 23, 2020 19:56
removed quickfixes added extra rule for Timed annotation
changed effort for annotations replacement added not-has-hint to global search
changed Javadoc links to the latest version of the artifact
mrizzi
reviewed
Apr 27, 2020
rules-reviewed/quarkus/springboot/springboot-metrics-to-quarkus.windup.xml
Outdated
Show resolved
Hide resolved
rules-reviewed/quarkus/springboot/springboot-metrics-to-quarkus.windup.xml
Outdated
Show resolved
Hide resolved
rules-reviewed/quarkus/springboot/springboot-metrics-to-quarkus.windup.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WINDUPRULE-476