-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Winduprule 475 spring integration quarkus #430
Winduprule 475 spring integration quarkus #430
Conversation
…tegration-core added test and test app
@jonathanvila - I have reviewed the rules and executed the tests. The rules all fired. They are nicely worded and the issue report links work and are appropriate. Regarding rule # 00000 I think the effort needs to be changed from 10 in keeping with the RHAMT SP documentation. https://access.redhat.com/documentation/en-us/red_hat_application_migration_toolkit/4.3/html/cli_guide/reference_material#how_story_points_are_estimated_in_rules. Thanks |
|
retest |
The rule tested successfully. Only one minor change required. Can the message for springboot-integration-to-quarkus-00000 be changed from "need" to "needs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comments, this PR is missing the technology usage rules that #429 has.
rules-reviewed/quarkus/springboot/springboot-integration-to-quarkus.windup.xml
Outdated
Show resolved
Hide resolved
rules-reviewed/quarkus/springboot/springboot-integration-to-quarkus.windup.xml
Outdated
Show resolved
Hide resolved
rules-reviewed/quarkus/springboot/springboot-integration-to-quarkus.windup.xml
Outdated
Show resolved
Hide resolved
rules-reviewed/quarkus/springboot/springboot-integration-to-quarkus.windup.xml
Outdated
Show resolved
Hide resolved
rules-reviewed/quarkus/springboot/springboot-integration-to-quarkus.windup.xml
Outdated
Show resolved
Hide resolved
rules-reviewed/quarkus/springboot/springboot-integration-to-quarkus.windup.xml
Outdated
Show resolved
Hide resolved
rules-reviewed/quarkus/springboot/springboot-integration-to-quarkus.windup.xml
Outdated
Show resolved
Hide resolved
@mrizzi : Spring Integration was already tackled by an old rule : https://github.com/windup/windup-rulesets/blob/master/rules-reviewed/technology-usage/integration.windup.xml#L45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @PhilipCattanach the titles of the hints (see screenshot)
It's better to have consistency so please change Integration flow
to become IntegrationFlow
In fact that's on purpose..... IntegrationFlow is a class, Integration flow is the concept |
…m:jonathanvila/windup-rulesets into WINDUPRULE-475-spring-integration-quarkus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jonathanvila 👍
https://issues.redhat.com/browse/WINDUPRULE-475