Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winduprule 475 spring integration quarkus #430

Merged

Conversation

jonathanvila
Copy link
Member

@jonathanvila jonathanvila commented Apr 1, 2020

@PhilipCattanach
Copy link
Contributor

@jonathanvila - I have reviewed the rules and executed the tests. The rules all fired. They are nicely worded and the issue report links work and are appropriate. Regarding rule # 00000 I think the effort needs to be changed from 10 in keeping with the RHAMT SP documentation. https://access.redhat.com/documentation/en-us/red_hat_application_migration_toolkit/4.3/html/cli_guide/reference_material#how_story_points_are_estimated_in_rules. Thanks

@jonathanvila
Copy link
Member Author

Regarding rule # 00000 I think the effort needs to be changed from 10 in keeping with the RHAMT SP documentation.
+1 , changed to 7

@jonathanvila
Copy link
Member Author

retest

@PhilipCattanach
Copy link
Contributor

The rule tested successfully. Only one minor change required. Can the message for springboot-integration-to-quarkus-00000 be changed from "need" to "needs"
Thank you.

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments, this PR is missing the technology usage rules that #429 has.

@jonathanvila
Copy link
Member Author

jonathanvila commented Apr 27, 2020

Other than the comments, this PR is missing the technology usage rules that #429 has.

@mrizzi : Spring Integration was already tackled by an old rule : https://github.com/windup/windup-rulesets/blob/master/rules-reviewed/technology-usage/integration.windup.xml#L45

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @PhilipCattanach the titles of the hints (see screenshot)
Screenshot from 2020-04-28 13-16-10

It's better to have consistency so please change Integration flow to become IntegrationFlow

@jonathanvila
Copy link
Member Author

Discussed with @PhilipCattanach the titles of the hints (see screenshot)
Screenshot from 2020-04-28 13-16-10

It's better to have consistency so please change Integration flow to become IntegrationFlow

In fact that's on purpose..... IntegrationFlow is a class, Integration flow is the concept
@PhilipCattanach @mrizzi are you still wanting me to change it ?

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonathanvila 👍

@mrizzi mrizzi merged commit 9b2a5f0 into windup:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants