Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winduprule-725-quarkus-12-mutiny #541

Merged
merged 7 commits into from
Mar 5, 2021
Merged

winduprule-725-quarkus-12-mutiny #541

merged 7 commits into from
Mar 5, 2021

Conversation

jonathanvila
Copy link
Member

@jonathanvila jonathanvila marked this pull request as ready for review March 4, 2021 10:01
@PhilipCattanach
Copy link
Contributor

PhilipCattanach commented Mar 4, 2021 •
edited
Loading

@jonathanvila Hi Jonathan - The rules look really good well done.

Just a couple of minor things.
Should the title for quarkus1-12-mutiny-000050 contain |bySkippingFirstItems

Could you change the message parts of the rules to highlight the method names

And include the arguments e.g. multi.select().where(Predicate <T>)

@PhilipCattanach PhilipCattanach merged commit 4dd29e7 into windup:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipCattanach PhilipCattanach Awaiting requested review from PhilipCattanach

Assignees
No one assigned
Labels
Ready to Review
Projects
None yet
Milestone
No milestone
2 participants
@jonathanvila @PhilipCattanach