Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winduprule-725-quarkus-12-mutiny #541

Merged
merged 7 commits into from
Mar 5, 2021
Merged

winduprule-725-quarkus-12-mutiny #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
76cb719
Added rule for mutiny
Mar 4, 2021
5de11b4
Added test rule with test files
Mar 4, 2021
a4ab313
Removed jar on test and adapted test rule
Mar 4, 2021
00e0d4e
Refined the 0050 rule
Mar 4, 2021
bd35054
[Pr] split rule into individual rules due to non expected behaviour w…
Mar 4, 2021
60ac26c
[PR] fixed test rule with the individual cases
Mar 4, 2021
d3b447e
[PR] fixing categories and cosmetic texts
Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
230 changes: 230 additions & 0 deletions rules-reviewed/quarkus1/quarkus1-11/quarkus1-12-mutiny.windup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,230 @@
<?xml version="1.0"?>
<ruleset xmlns="http://windup.jboss.org/schema/jboss-ruleset" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://windup.jboss.org/schema/jboss-ruleset http://windup.jboss.org/schema/jboss-ruleset/windup-jboss-ruleset.xsd" id="quarkus1-12-mutiny">
<metadata>
<description>
This ruleset gives hints for upgrading to quarkus 1.12 for applications that use Mutiny
</description>
<dependencies>
<addon id="org.jboss.windup.rules,windup-rules-javaee,3.0.0.Final"/>
<addon id="org.jboss.windup.rules,windup-rules-java,3.0.0.Final"/>
<addon id="org.jboss.windup.rules,windup-rules-xml,3.0.0.Final"/>
</dependencies><!-- The major version is implied by the target, the minor is reflected in the verionRange -->
<sourceTechnology id="quarkus1" versionRange="(,11]"/>
<targetTechnology id="quarkus1" versionRange="[12,)"/>
</metadata>
<rules>
<rule id="quarkus1-12-mutiny-00010">
<when>
<javaclass references="io.smallrye.mutiny.Multi" as="files1">
<location>IMPORT</location>
</javaclass>
<filecontent pattern="{*}.collectItems(){*}" from="files1" as="methods1" />
</when>
<perform>
<iteration over="methods1">
<hint title="Method Multi.collectItems() deprecated" effort="1" category-id="potential">
<message>
<![CDATA[
Mutiny has deprecated a few APIs. The deprecated APIs are still available and would work, but are planned for removal.
Changed API is : `Multi.collectItems()` -> `Multi.collect()`
]]>
</message>
<link title="Quarkus - Migration Guide 1.12" href="https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.12#mutiny"/>
<quickfix type="REPLACE" name="collectItems">
<replacement>.collect(</replacement>
<search>.collectItems(</search>
</quickfix>
</hint>
</iteration>
</perform>
</rule>
<rule id="quarkus1-12-mutiny-00020">
<when>
<javaclass references="io.smallrye.mutiny.Multi" as="files2">
<location>IMPORT</location>
</javaclass>
<filecontent pattern="{*}.groupItems(){*}" from="files2" as="methods2" />
</when>
<perform>
<iteration over="methods2">
<hint title="Method Multi.groupItems() deprecated" effort="1" category-id="potential">
<message>
<![CDATA[
Mutiny has deprecated a few APIs. The deprecated APIs are still available and would work, but are planned for removal.
Changed API is : `Multi.groupItems()` -> `Multi.group()`
]]></message>
<link title="Quarkus - Migration Guide 1.12" href="https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.12#mutiny"/>
<quickfix type="REPLACE" name="groupItems">
<replacement>.group(</replacement>
<search>.groupItems(</search>
</quickfix>
</hint>
</iteration>
</perform>
</rule>
<rule id="quarkus1-12-mutiny-00030">
<when>
<javaclass references="io.smallrye.mutiny.Multi" as="files3">
<location>IMPORT</location>
</javaclass>
<filecontent pattern="{*}.toHotStream(){*}" from="files3" as="methods3" />
</when>
<perform>
<iteration over="methods3">
<hint title="Method Multi.transform().toHotStream() deprecated" effort="1" category-id="potential">
<message>
<![CDATA[
Mutiny has deprecated a few APIs. The deprecated APIs are still available and would work, but are planned for removal.
Changed API is : `Multi.transform().toHotStream()` -> `Multi.toHotStream()`
]]></message>
<link title="Quarkus - Migration Guide 1.12" href="https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.12#mutiny"/>
<quickfix type="REPLACE" name="toHotStream">
<replacement>.toHotStream(</replacement>
<search>.transform().toHotStream(</search>
</quickfix>
</hint>
</iteration>
</perform>
</rule>
<rule id="quarkus1-12-mutiny-00040">
<when>
<javaclass references="io.smallrye.mutiny.Multi" as="files4">
<location>IMPORT</location>
</javaclass>
<filecontent pattern="{*}.subscribeOn{*}" from="files4" as="methods4" />
</when>
<perform>
<iteration over="methods4">
<when>
<not>
<has-hint />
</not>
</when>
<perform>
<hint title="Method subscribeOn() removed" effort="1" category-id="mandatory">
<message>
<![CDATA[
Mutiny has removed this method (deprecated for 11 months): `Multi.subscribeOn` -> `Multi.runSubscriptionOn()`
]]></message>
<link title="Quarkus - Migration Guide 1.12" href="https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.12#mutiny"/>
<quickfix type="REPLACE" name="subscribeOn">
<replacement>.runSubscriptionOn(</replacement>
<search>.subscribeOn(</search>
</quickfix>
</hint>
</perform>
</iteration>
</perform>
</rule>
<rule id="quarkus1-12-mutiny-00045">
<when>
<javaclass references="io.smallrye.mutiny.Uni" as="files5">
<location>IMPORT</location>
</javaclass>
<filecontent pattern="{*}.subscribeOn{*}" from="files5" as="methods5" />
</when>
<perform>
<iteration over="methods5">
<when>
<not>
<has-hint />
</not>
</when>
<perform>
<hint title="Method subscribeOn() removed" effort="1" category-id="mandatory">
<message>
<![CDATA[
Mutiny has removed this method (deprecated for 11 months): `Uni.subscribeOn` -> `Uni.runSubscriptionOn()`
]]></message>
<link title="Quarkus - Migration Guide 1.12" href="https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.12#mutiny"/>
<quickfix type="REPLACE" name="subscribeOn">
<replacement>.runSubscriptionOn(</replacement>
<search>.subscribeOn(</search>
</quickfix>
</hint>
</perform>
</iteration>
</perform>
</rule>
<rule id="quarkus1-12-mutiny-00050">
<when>
<javaclass references="io.smallrye.mutiny.Multi" as="files6">
<location>IMPORT</location>
</javaclass>
<filecontent pattern="{*}.byTakingFirstItems{*}" from="files6" as="methods6"/>
</when>
<perform>
<iteration over="methods6">
<hint title="Methods byTakingFirstItems has been deprecated" effort="1" category-id="potential">
<message>
<![CDATA[
Mutiny has deprecated a few APIs. The deprecated APIs are still available and would work, but are planned for removal.
Changed API is : `Multi.transform().byTakingFirstItems(long)` -> `Multi.select().first(long)`
]]></message>
<link title="Quarkus - Migration Guide 1.12" href="https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.12#mutiny"/>
</hint>
</iteration>
</perform>
</rule>
<rule id="quarkus1-12-mutiny-00051">
<when>
<javaclass references="io.smallrye.mutiny.Multi" as="files6">
<location>IMPORT</location>
</javaclass>
<filecontent pattern="{*}.byTestingItemsWith{*}" from="files6" as="methods6"/>
</when>
<perform>
<iteration over="methods6">
<hint title="Method byTestingItemsWith has been deprecated" effort="1" category-id="potential">
<message>
<![CDATA[
Mutiny has deprecated a few APIs. The deprecated APIs are still available and would work, but are planned for removal.
Changed API is : `Multi.transform().byTestingItemsWith(Function<T, Uni<?>>)` -> `Multi.select().when(Function<T, Uni<?>>)`
]]></message>
<link title="Quarkus - Migration Guide 1.12" href="https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.12#mutiny"/>
</hint>
</iteration>
</perform>
</rule>
<rule id="quarkus1-12-mutiny-00052">
<when>
<javaclass references="io.smallrye.mutiny.Multi" as="files6">
<location>IMPORT</location>
</javaclass>
<filecontent pattern="{*}.byFilteringItemsWith{*}" from="files6" as="methods6"/>
</when>
<perform>
<iteration over="methods6">
<hint title="Method byFilteringItemsWith has been deprecated" effort="1" category-id="potential">
<message>
<![CDATA[
Mutiny has deprecated a few APIs. The deprecated APIs are still available and would work, but are planned for removal.
Changed API is : `Multi.transform().byFilteringItemsWith(Predicate<T>)` -> `Multi.select().where(Predicate<T>)`
]]></message>
<link title="Quarkus - Migration Guide 1.12" href="https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.12#mutiny"/>
</hint>
</iteration>
</perform>
</rule>
<rule id="quarkus1-12-mutiny-00053">
<when>
<javaclass references="io.smallrye.mutiny.Multi" as="files6">
<location>IMPORT</location>
</javaclass>
<filecontent pattern="{*}.bySkippingFirstItems{*}" from="files6" as="methods6"/>
</when>
<perform>
<iteration over="methods6">
<hint title="Method bySkippingFirstItems has been deprecated" effort="1" category-id="potential">
<message>
<![CDATA[
Mutiny has deprecated a few APIs. The deprecated APIs are still available and would work, but are planned for removal.
Changed API is : `Multi.transform().bySkippingFirstItems(long)` -> `Multi.skip().first(long)`
]]></message>
<link title="Quarkus - Migration Guide 1.12" href="https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.12#mutiny"/>
</hint>
</iteration>
</perform>
</rule>
</rules>
</ruleset>
63 changes: 63 additions & 0 deletions rules-reviewed/quarkus1/quarkus1-11/tests/data/mutiny/FruitAsyncService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
package org.acme.dynamodb;

import java.util.List;
import java.util.stream.Collectors;

import javax.enterprise.context.ApplicationScoped;
import javax.inject.Inject;

import io.smallrye.mutiny.Multi;
import software.amazon.awssdk.services.dynamodb.DynamoDbAsyncClient;

@ApplicationScoped
public class FruitAsyncService extends AbstractService {

@Inject
DynamoDbAsyncClient dynamoDB;

public Uni<List<Fruit>> findAll() {
return Uni.createFrom().completionStage(() -> dynamoDB.scan(scanRequest()))
.onItem().transform(res -> res.items().stream().map(Fruit::from).collect(Collectors.toList()));
}

public Uni<List<Fruit>> add(Fruit fruit) {
return Uni.createFrom().completionStage(() -> dynamoDB.putItem(putRequest(fruit)))
.onItem().ignore().andSwitchTo(this::findAll);
}

public Uni<Fruit> get(String name) {
return Uni.createFrom().completionStage(() -> dynamoDB.getItem(getRequest(name)))
.onItem().transform(resp -> Fruit.from(resp.item()));
}

public void testRule() {
Multi<Long> multiLong = Multi.createFrom().ticks().every(Duration.ofMillis(500));

Multi<Object> multiObject = (Multi<Object>) Multi.createFrom().empty();
Multi multiEmpty = Multi.createFrom().empty();

multiLong.collectItems();
multiObject.collectItems();
multiEmpty.collectItems();

multiLong.groupItems();
multiObject.groupItems();
multiEmpty.groupItems();
multiEmpty.groupItems();

multiLong.transform().toHotStream();
multiLong.transform().toHotStream();
multiObject.transform().toHotStream();
multiObject.transform().toHotStream();
multiEmpty.transform().toHotStream();

multiLong.subscribeOn(Executors.newSingleThreadExecutor());
multiLong.subscribeOn(Executors.newSingleThreadExecutor());
multiLong.subscribeOn(Executors.newSingleThreadExecutor());

multiLong.transform().byFilteringItemsWith(e -> e == 10L);
multiObject.transform().byTakingFirstItems(3L);
multiObject.transform().bySkippingFirstItems(3L);
multiEmpty.transform().byTestingItemsWith(e -> Uni.createFrom().item(Boolean.TRUE));
}
}
33 changes: 33 additions & 0 deletions rules-reviewed/quarkus1/quarkus1-11/tests/data/mutiny/FruitAsyncService2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package org.acme.dynamodb;

import java.util.List;
import java.util.stream.Collectors;

import javax.enterprise.context.ApplicationScoped;
import javax.inject.Inject;

import io.smallrye.mutiny.Multi;
import software.amazon.awssdk.services.dynamodb.DynamoDbAsyncClient;

@ApplicationScoped
public class FruitAsyncService2 extends AbstractService {

@Inject
DynamoDbAsyncClient dynamoDB;

public Uni<List<Fruit>> findAll() {
return Uni.createFrom().completionStage(() -> dynamoDB.scan(scanRequest()))
.onItem().transform(res -> res.items().stream().map(Fruit::from).collect(Collectors.toList()));
}

public Uni<List<Fruit>> add(Fruit fruit) {
return Uni.createFrom().completionStage(() -> dynamoDB.putItem(putRequest(fruit)))
.onItem().ignore().andSwitchTo(this::findAll);
}

public Uni<Fruit> get(String name) {
return Uni.createFrom().completionStage(() -> dynamoDB.getItem(getRequest(name)))
.onItem().transform(resp -> Fruit.from(resp.item()));
}

}
62 changes: 62 additions & 0 deletions rules-reviewed/quarkus1/quarkus1-11/tests/data/mutiny/FruitAsyncService3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
package org.acme.dynamodb;

import java.util.List;
import java.util.stream.Collectors;

import javax.enterprise.context.ApplicationScoped;
import javax.inject.Inject;

import software.amazon.awssdk.services.dynamodb.DynamoDbAsyncClient;

@ApplicationScoped
public class FruitAsyncService3 extends AbstractService {

@Inject
DynamoDbAsyncClient dynamoDB;

public Uni<List<Fruit>> findAll() {
return Uni.createFrom().completionStage(() -> dynamoDB.scan(scanRequest()))
.onItem().transform(res -> res.items().stream().map(Fruit::from).collect(Collectors.toList()));
}

public Uni<List<Fruit>> add(Fruit fruit) {
return Uni.createFrom().completionStage(() -> dynamoDB.putItem(putRequest(fruit)))
.onItem().ignore().andSwitchTo(this::findAll);
}

public Uni<Fruit> get(String name) {
return Uni.createFrom().completionStage(() -> dynamoDB.getItem(getRequest(name)))
.onItem().transform(resp -> Fruit.from(resp.item()));
}

public void testRule() {
Multi<Long> multiLong = Multi.createFrom().ticks().every(Duration.ofMillis(500));
multiLong.collectItems();

Multi<Object> multiObject = Multi.createFrom().ticks().every(Duration.ofMillis(500));
Multi multiEmpty = Multi.createFrom().ticks().every(Duration.ofMillis(500));

multiObject.collectItems();
multiEmpty.collectItems();

multiLong.groupItems();
multiLong.groupItems();
multiLong.groupItems();

multiLong.transform().toHotStream();
multiLong.transform().toHotStream();

multiLong.subscribeOn(new Object());
multiLong.subscribeOn(new Object());
multiLong.subscribeOn(new Object());

Uni uniLong = Uni.createFrom().nothing();
uniLong.subscribeOn(new Object());
uniLong.subscribeOn(new Object());
uniLong.subscribeOn(new Object());

multiLong.transform().first();
multiLong.transform().filter(myFilter);
multiLong.transform().test(myTest);
}
}
Loading