Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUPRULE-942 allow eap7 source #840

Merged
merged 9 commits into from
Jan 17, 2023
Merged

Conversation

m-brophy
Copy link
Contributor

@m-brophy m-brophy commented Jan 13, 2023

@m-brophy m-brophy requested a review from mrizzi January 13, 2023 14:58
@m-brophy m-brophy changed the title WINDUPRULE-894 allow eap7 source WINDUPRULE-942 allow eap7 source Jan 16, 2023
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with --source eap7 --target eap8 and the rules worked.
Thanks @m-brophy 👍

@mrizzi mrizzi added auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch labels Jan 17, 2023
@mrizzi mrizzi merged commit a88a586 into windup:master Jan 17, 2023
github-actions bot pushed a commit that referenced this pull request Jan 17, 2023
* WINDUPRULE-894: tests added

* added namespace data into rule and test

* eap8-faces rules

* Faces 4 JSP rule not working

* WINDUPRULE-894: identify a jsp file in rule

* WINDUPRULE-894: alter markup in rule message

(cherry picked from commit a88a586)
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
releases/6.1.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit that referenced this pull request Jan 17, 2023
* WINDUPRULE-894: tests added

* added namespace data into rule and test

* eap8-faces rules

* Faces 4 JSP rule not working

* WINDUPRULE-894: identify a jsp file in rule

* WINDUPRULE-894: alter markup in rule message

(cherry picked from commit a88a586)

Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.1.z Backport this issue to releases/6.1.z branch Ready to Review
Projects
None yet
2 participants