-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WINDUPRULE-942 allow eap7 source #840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-brophy
changed the title
WINDUPRULE-894 allow eap7 source
WINDUPRULE-942 allow eap7 source
Jan 16, 2023
mrizzi
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with --source eap7 --target eap8
and the rules worked.
Thanks @m-brophy 👍
mrizzi
added
auto-backport
Set the PR for being backported
auto-backport-to-releases/6.1.z
Backport this issue to releases/6.1.z branch
labels
Jan 17, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2023
* WINDUPRULE-894: tests added * added namespace data into rule and test * eap8-faces rules * Faces 4 JSP rule not working * WINDUPRULE-894: identify a jsp file in rule * WINDUPRULE-894: alter markup in rule message (cherry picked from commit a88a586)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mrizzi
pushed a commit
that referenced
this pull request
Jan 17, 2023
* WINDUPRULE-894: tests added * added namespace data into rule and test * eap8-faces rules * Faces 4 JSP rule not working * WINDUPRULE-894: identify a jsp file in rule * WINDUPRULE-894: alter markup in rule message (cherry picked from commit a88a586) Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Set the PR for being backported
auto-backport-to-releases/6.1.z
Backport this issue to releases/6.1.z branch
Ready to Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WINDUPRULE-942