Task 572: Configuration Page (settings and kick off windup) #278
Conversation
|
@klinki - I am requesting your review as I ran into some issues with the chosen-multiple component. Can you take a look and see if my changes here are reasonable? The "select all", "select none", and all selected states are still a WIP at the moment. |
|
@jsight It seems fine. |
jsight
force-pushed
the
task_572_configuration_application_selection
branch
from
d427343
to
b087af0
Compare
|
@klinki - Ok, functionality is ready to review now. |
| @Input() | ||
| set selectedApps(apps:RegisteredApplication[]) { | ||
| this._selectedApps = apps; | ||
| this.selectedAppsChange.emit(this._selectedApps); |
There was a problem hiding this comment.
I'm surprised Angular is not complaining about this one. It is changing the value in @input. Angular usually triggers some ugly exceptions like
item modified after it has been checked
or something like that... Maybe it is intelligent enough not to complain, when you emit the same value as was the input one :)
There was a problem hiding this comment.
I'm not totally sure that I understand what you mean. It isn't changing anything other than the property being @input() is it?
| equalsCallback = (a1: RegisteredApplication, a2: RegisteredApplication) => a1.id === a2.id; | ||
|
|
||
| selectAll() { | ||
| this.selectedApps = this.availableApps; |
There was a problem hiding this comment.
You got me, I wanted to say you forgot to emit, but you use set property so it actually gets called... :)
There was a problem hiding this comment.
Yeah, it is relying on the setter property. :)
This changes the process of configuring Windup to allow for easier selection of applications.
… "select none" buttons.
jsight
force-pushed
the
task_572_configuration_application_selection
branch
from
e4a264d
to
c887e85
Compare
This changes the process of configuring Windup to allow for easier selection of applications.