Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WINDUP-3845] - Project details: Need to click twice the "Next" button to proceed to the next step #918

Merged
merged 1 commit into from
May 8, 2023

Conversation

carlosthe19916
Copy link
Member

@carlosthe19916 carlosthe19916 commented May 4, 2023

https://issues.redhat.com/browse/WINDUP-3845

Issue introduced at #865 when upgrading the library formik. An old version behaves differently than the last version.

How to reproduce the issue in current master branch

  • Have windup web console running locally
  • Try to create a new project
  • Use Chrome + use Chrome tools to make the network really slow (see image below)
  • After filling the name of the project try to click on "Next"

Screenshot from 2023-05-04 16-23-42

Explanation to the issue: the form is being validated in both "When the form changes" and "on blur (when the input boxes lose the focus)". When the user fills the input boxes and tries to click on "Next" the "onBlur" validation is fired blocking the "Next" button and not allowing it to go to the next page.

@mrizzi mrizzi self-requested a review May 8, 2023 11:03
@mrizzi mrizzi added auto-backport Set the PR for being backported auto-backport-to-releases/6.2.z Backport this issue to releases/6.2.z branch labels May 8, 2023
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully, thanks @carlosthe19916 👍

@mrizzi mrizzi merged commit 4392895 into windup:master May 8, 2023
8 checks passed
github-actions bot pushed a commit that referenced this pull request May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

💚 All backports created successfully

Status Branch Result
releases/6.2.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit that referenced this pull request May 9, 2023
(cherry picked from commit 4392895)

Co-authored-by: Carlos E. Feria Vila <carlosthe19916@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.2.z Backport this issue to releases/6.2.z branch Ready to Review
Projects
None yet
2 participants