Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windup 1548 fix #1143

Closed
wants to merge 3 commits into from
Closed

Windup 1548 fix #1143

wants to merge 3 commits into from

Conversation

Maarc
Copy link
Contributor

@Maarc Maarc commented Jul 13, 2017

Avoid building the very costly to build String if there is no need to log it.

@OndraZizka
Copy link
Contributor

OndraZizka commented Jul 13, 2017 •
edited

I forgot to make it a lambda...
Here is how it should have been, if I am not mistaken, it effectively does the same as this PR.
PR #1144

@OndraZizka OndraZizka mentioned this pull request Jul 13, 2017
Merged
@jsight
Copy link
Member

jsight commented Jul 17, 2017

Fixed in a slightly different way by @OndraZizka here: #1144

@jsight jsight closed this Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Maarc @OndraZizka @jsight