Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use freemarker updates #1187

Merged
merged 7 commits into from
Oct 17, 2017
Merged

Conversation

OndraZizka
Copy link
Contributor

@OndraZizka OndraZizka commented Sep 26, 2017

Seems to work fine. I didn't check all reports but no errors were thrown with sample app.

@mareknovotny
Copy link
Contributor

it seems your changes in templates broke HTMLUnit tests which relies on some xpaths.

@OndraZizka
Copy link
Contributor Author

OK I'll check that

@OndraZizka
Copy link
Contributor Author

If someone has a moment to have a look at this before I do, It would be appreciated.

@OndraZizka
Copy link
Contributor Author

OndraZizka commented Oct 15, 2017

WARNING: Failed to render freemarker report:
[v[39424]={templateType: FREEMARKER, w:winduptype: [ApplicationReportModel, ReportModel], reportName: Compatible Files, reportFilename: compatiblefiles_catchalltest.html, mainApplicationModel: false, reportPriority: 200, reportDescription: ..., ... templatePath: /reports/templates/compatible_files.ftl, displayInApplicationReportIndex: true}]

freemarker.template.DefaultIterableAdapter cannot be cast to freemarker.ext.beans.StringModel

java.lang.ClassCastException: freemarker.template.DefaultIterableAdapter cannot be cast to freemarker.ext.beans.StringModel
at org.jboss.windup.rules.apps.java.reporting.freemarker.FindFilesNotClassifiedOrHinted.exec(FindFilesNotClassifiedOrHinted.java:57)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

@OndraZizka
Copy link
Contributor Author

Oct 15, 2017 3:26:09 AM org.jboss.windup.reporting.rules.rendering.RenderReportRuleProvider$FreeMarkerThreadedRenderer$1 call
WARNING: Failed to render freemarker report:
[v[38912]={templateType: FREEMARKER, w:winduptype: [JavaApplicationOverviewReportModel, ApplicationReportModel, ReportModel], reportName: Application Details, reportFilename: ApplicationDetails_catchalltest.html, mainApplicationModel: false, reportPriority: 102, reportDescription: An exhaustive list of all of the information and issues found within the application., reportIconClass: glyphicon glyphicon-th-list, templatePath: /reports/templates/java_application.ftl, excludeTags:catchall: 1, displayInApplicationReportIndex: true}]
Unrecognized type passed to: iterableHasContent: freemarker.template.DefaultIterableAdapter
org.jboss.windup.util.exception.WindupException: Unrecognized type passed to: iterableHasContent: freemarker.template.DefaultIterableAdapter
at org.jboss.windup.rules.apps.java.reporting.freemarker.IterableHasContent.hasContent(IterableHasContent.java:71)
at org.jboss.windup.rules.apps.java.reporting.freemarker.IterableHasContent.exec(IterableHasContent.java:39)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

@OndraZizka
Copy link
Contributor Author

retest

@mareknovotny mareknovotny merged commit 13d8ea9 into windup:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants