Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUP-1758 WINDUP-1768 CLI option in list* commands #1219

Merged
merged 2 commits into from
Nov 10, 2017

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented Nov 2, 2017

The first commit has only the changes for ListTagsCommand.
If these changes are good, then i'll apply the same to ListSourceTechnologiesCommand and ListTargetTechnologiesCommand.

With these changes:

  • executing CLI only with --listTags option still executes directly w/o any delay
  • executing CLI with --listTags and --userRulesDirectory /path/ options takes 5 seconds because it needs a RuleProviderRegistryCache from Furnace to get all the available tags from all the rules available

@jsight
Copy link
Member

jsight commented Nov 2, 2017

This seems like a good approach to me.

@mrizzi
Copy link
Member Author

mrizzi commented Nov 3, 2017

bcf7584 commit:

  • refactored List<Path> getUserProvidedPaths(List<String> arguments) method in AbstractListCommand to check also the ~/.rhamt/rules path for rules
  • changes applied also to ListSourceTechnologiesCommand and ListTargetTechnologiesCommand

@windup windup deleted a comment from windupgithubbot1 Nov 6, 2017
@windup windup deleted a comment from windupgithubbot1 Nov 6, 2017
@windup windup deleted a comment from windupgithubbot1 Nov 6, 2017
@windup windup deleted a comment from windupgithubbot1 Nov 6, 2017
@windup windup deleted a comment from windupgithubbot1 Nov 6, 2017
@windup windup deleted a comment from windupgithubbot1 Nov 6, 2017
@jsight
Copy link
Member

jsight commented Nov 6, 2017

retest

@mrizzi mrizzi changed the title WINDUP-1758 CLI option in list* commands WINDUP-1758 WINDUP-1768 CLI option in list* commands Nov 8, 2017
@jsight
Copy link
Member

jsight commented Nov 10, 2017

lgtm

@mrizzi mrizzi merged commit 78f2dfd into windup:master Nov 10, 2017
@mrizzi mrizzi deleted the JIRA_WINDUP-1758 branch November 10, 2017 16:37
mrizzi added a commit to mrizzi/windup that referenced this pull request Nov 10, 2017
* WINDUP-1758 CLI  option in list* commands

* WINDUP-1758 CLI option in list* commands: improved implementation
mrizzi added a commit that referenced this pull request Nov 10, 2017
* WINDUP-1758 CLI  option in list* commands

* WINDUP-1758 CLI option in list* commands: improved implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants