Maarc summit2018 #1309
Maarc summit2018 #1309
Conversation
|
retest |
|
@mrizzi - Perhaps we should go ahead and merge this one? |
…ly throw a concurrent modification exception
There was a problem hiding this comment.
There are still some small changes needed to fix the "bubbles" report.
Here the list of the changes in this PR:
- Reports: tooltips in pages
- Technologies report: columns rewording and lexicographical ordering
- Technologies report: added "Database Driver" and changed icons
- Application List: wider input field in search box
- Reports: minor UI changes
| <#if !isTagUnderTag(boxTag, placeTagsParent) > | ||
| <#assign techsOrder = techsOrder + [boxTag] /> | ||
| <td class="sector sector${sectorTag.title}"><div>${boxTag.title!}</div></td> | ||
| </#if> | ||
| </#list> | ||
| </#list> | ||
| <td class="sector sectorStats sizeMB"><div>Size (MB)</div></td> | ||
| <td class="sector sectorStats libsCount"><div>Libraries</div></td> | ||
| <#-- <td class="sector sectorStats libsCount"><div>Libraries</div></td> --> |
There was a problem hiding this comment.
This can be uncommented since libraries count has been fixed (WINDUP-1967 - PR-1296) so we can have Libraries column again (ref. this comment)
There was a problem hiding this comment.
Oops... yes, it should have been.
| table.technologiesPunchCard thead tr td:nth-last-child(3) { width: 70px; min-width: 70px; max-width: 70px; } | ||
|
|
||
| table.technologiesPunchCard tbody tr td:nth-last-child(2), | ||
| table.technologiesPunchCard thead tr td:nth-last-child(2) { width: 57px; min-width: 57px; max-width: 57px; } |
There was a problem hiding this comment.
I think all these changes should be reverted because having the Libraries column back, makes it appearing not aligned as in the next screenshot.
I tried to replace it locally on a static report and with the "old" CSS:
table.technologiesPunchCard tbody tr td:nth-last-child(2),
table.technologiesPunchCard tbody tr td:nth-last-child(3),
table.technologiesPunchCard tbody tr td:nth-last-child(4),
table.technologiesPunchCard thead tr td:nth-last-child(2),
table.technologiesPunchCard thead tr td:nth-last-child(3),
table.technologiesPunchCard thead tr td:nth-last-child(4) {
width: 57px;
min-width: 57px;
max-width: 57px;
}
The columns look like:
There was a problem hiding this comment.
Hi!
Can you also make sure that ...
table.technologiesPunchCard thead tr td:nth-last-child(3) { width: 70px; min-width: 70px; max-width: 70px; }
... is kept?
Probably you will need to update it to
table.technologiesPunchCard thead tr td:nth-last-child(4) { width: 70px; min-width: 70px; max-width: 70px; }
There was a problem hiding this comment.
Ok, so talking in terms of requirements, your request is to have wider columns in Stats section, right? So that numbers have more space to be displayed.
Having only more width for table cell (setting their width to 70px), like in the screenshot above, will cause a misalignment between labels and values just like in the next screenshot.
We can work on inner <div> to better place the text to obtain something like this:
where both Size (MB) and Libraries labels are aligned with the data below them.
@jsight i use an in-line style for div width: inherit;transform: rotate(180deg) translateX(30%);
There was a problem hiding this comment.
The wider column was only for ":nth-last-child(3)" -> the "Size (MB)" column.
There was a problem hiding this comment.
Ok, great, thanks @Maarc: only Size (MB) column wider 👍
| @@ -41,7 +41,7 @@ | |||
| public static final String TEMPLATE_REPORT = "/reports/templates/ignored_files.ftl"; | |||
| public static final String DESCRIPTION = "This report lists the files in the application that have not been processed based on certain rules and the " + | |||
| Util.WINDUP_BRAND_NAME_LONG + | |||
| " configuration. See the <code>--userIgnorePath</code> option in the <a href=\"https://access.redhat.com/documentation/en-us/red_hat_application_migration_toolkit/\">User Guide</a>."; | |||
| " configuration. See the '--userIgnorePath' option in the User Guide (https://access.redhat.com/documentation/en-us/red_hat_application_migration_toolkit)."; | |||
There was a problem hiding this comment.
TBH, in this case having a tooltip is not so useful for the user since the link is not a link any more and even copy&paste it's really hard (need to use the source of the page)
There was a problem hiding this comment.
I noticed that too. As the link is probably on the "About" page anyway, what about removing the link?
There was a problem hiding this comment.
For me it's fine.
@jeichler are you ok with removing the URL within the brackets from the tooltip?
There was a problem hiding this comment.
@mrizzi ack, fine with me too.
| @@ -89,14 +90,12 @@ | |||
| <div class="row"> | |||
| <div class="page-header page-header-no-border"> | |||
| <h1> | |||
| <div class="main">${reportModel.reportName}</div> | |||
| <div class="main">${reportModel.reportName} | |||
| <i class="glyphicon glyphicon-info-sign" data-toggle="tooltip" data-placement=right title="${reportModel.description}."></i></div> | |||
There was a problem hiding this comment.
The dot . after ${reportModel.description} has to be removed
|
|
||
| <div class="container-fluid" role="main"> | ||
| <div class="row"> | ||
| <div class="page-header page-header-no-border"> | ||
| <h1> | ||
| <div class="main">${reportModel.reportName}</div> | ||
| <div class="main">${reportModel.reportName} | ||
| <i class="glyphicon glyphicon-info-sign" data-toggle="tooltip" data-placement=right title="${reportModel.description}."></i></div> |
There was a problem hiding this comment.
The dot . after ${reportModel.description} has to be removed
Rebased to master.
Original PR: #1306
https://issues.jboss.org/browse/WINDUP-2021