Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUPRULE-355 Move informational rules to a dedicated issue category #1331

Merged
merged 4 commits into from Sep 14, 2018
Merged

WINDUPRULE-355 Move informational rules to a dedicated issue category #1331

merged 4 commits into from Sep 14, 2018

Conversation

jeichler
Copy link
Contributor

@jeichler jeichler commented Sep 10, 2018

@windupgithubbot1
Copy link

Can one of the admins verify this patch?

@mrizzi mrizzi changed the title https://issues.jboss.org/browse/WINDUPRULE-355 WINDUPRULE-355 Move informational rules to a dedicated issue category Sep 13, 2018
@mrizzi
Copy link
Member

mrizzi commented Sep 13, 2018

retest

@windup windup deleted a comment from windupgithubbot1 Sep 13, 2018
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeichler : this PR is very good.
I just ask you to change or remove one assertion in a test and then i'll merge it.

Assert.assertTrue(util.checkIncidentByCategoryRow("cloud-mandatory", 3, 3));
Assert.assertTrue(util.checkIncidentByCategoryRow("mandatory", 0, 0));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a duplicate so it can be removed or (maybe better) changed to potential.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mrizzi
Copy link
Member

mrizzi commented Sep 14, 2018

retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants