WINDUP-2032: sort tech bubble report by sector header #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest |
mrizzi
reviewed
Feb 6, 2019
|
Problem identified with the column sorting, but the Tier sorting looks fine. Details attached to the Jira. |
carlosthe19916
requested changes
Feb 15, 2019
| $('.technologiesPunchCard').children('tbody').append(row); | ||
| }); | ||
| } | ||
|
|
||
| $().ready(function () { | ||
| $(".headersGroup .sector").click(function (event) { | ||
| var td = event.target.parentNode; |
There was a problem hiding this comment.
I noticed that every column of the header has a div inside, but because the div is shorter than the column(td) there is a problem when I click on the space between the div and the td (I'm attaching an image to explain this better)...
The problem is that whenever I click in the yellow part of the image the sort column is always the first one and not the column selected.
|
Tested successfully after running an analysis using the 40 Sample Apps |
reporting/impl/src/main/resources/reports/templates/techReport-punchCard.ftl
Outdated
Show resolved
Hide resolved
jonathanvila
approved these changes
Mar 28, 2019
|
I'll put in some meaningful variable names before it gets merged
…On Thu, 28 Mar 2019 at 16:50, Jonathan Vila ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1346 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AjPlSxq22Jhez7uyMMDTLH9k1whQp57Sks5vbPLagaJpZM4alDL2>
.
|
|
variable names changed as per @jonathanvila review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.