Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUP-2564 Rebranding to MTA #1383

Merged
merged 13 commits into from Jun 17, 2020
Merged

Conversation

m-brophy
Copy link
Contributor

@m-brophy m-brophy commented Jun 3, 2020

Mark Brophy added 4 commits June 1, 2020 18:27
t
e Pleas enter the commit message for your changes. Lines starting
@m-brophy m-brophy changed the title WiINDUP-2564 WiINDUP-2564 Rebranding to MTA Jun 3, 2020
@m-brophy m-brophy changed the title WiINDUP-2564 Rebranding to MTA WINDUP-2564 Rebranding to MTA Jun 4, 2020
t Please enter the commit message for your changes. Lines starting
@m-brophy
Copy link
Contributor Author

m-brophy commented Jun 5, 2020

retest

@m-brophy m-brophy requested a review from mrizzi June 9, 2020 15:08
@carlosthe19916
Copy link
Member

@m-brophy @PhilipCattanach This is completely just a suggestion. I think we can add a "Margin of 10px" to the right of the logo which is located in the header(right part) to make it look better.

Current version:
Screenshot from 2020-06-15 18-25-48

After applying margin
Screenshot from 2020-06-15 18-26-18

Pay attention to the "Red Hat" logo in the header

@PhilipCattanach
Copy link
Contributor

@m-brophy @PhilipCattanach This is completely just a suggestion. I think we can add a "Margin of 10px" to the right of the logo which is located in the header(right part) to make it look better.

Current version:
Screenshot from 2020-06-15 18-25-48

After applying margin
Screenshot from 2020-06-15 18-26-18

Pay attention to the "Red Hat" logo in the header

@carlosthe19916 Yes I agree that looks a lot better with the margin. Thanks

@m-brophy
Copy link
Contributor Author

Margin added to logo, much better, thanks

@PhilipCattanach
Copy link
Contributor

PhilipCattanach commented Jun 16, 2020 via email

@carlosthe19916
Copy link
Member

@m-brophy just to keep track of what I've already reported.

  • The "Red Hat" logo is not visible. It is only visible in the "Report List page" but not in the rest of the pages.
  • The "Twitter" link in the "About" page might be hidden because we don't have a Twitter account yet.

Screenshot from 2020-06-16 11-38-29

@m-brophy
Copy link
Contributor Author

logo issue should be fixed now

@PhilipCattanach
Copy link
Contributor

@m-brophy @carlosthe19916 Mark - I have just rebuild the CLI and gave it a quick test. It looks great. Thanks!

@carlosthe19916
Copy link
Member

I've tested this PR again and it looks good to me. Thanks @m-brophy

@carlosthe19916 carlosthe19916 merged commit 8b7947a into windup:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants