Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some Eclipse dependencies version to avoid issues with latest releases #1502

Merged
merged 6 commits into from Jun 16, 2022

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented Jun 15, 2022

The builds are failing from yesterday with the message:

[ERROR] Failed to execute goal on project windup-eclipse-jdt: Could not resolve dependencies for project org.jboss.windup.jdt:windup-eclipse-jdt:jar:5.3.1-SNAPSHOT: Failed to collect dependencies at org.eclipse.jdt:org.eclipse.jdt.core:jar:3.16.0 -> org.eclipse.platform:org.eclipse.core.resources:jar:3.13.200 -> org.eclipse.platform:org.eclipse.core.expressions:jar:3.5.100 -> org.eclipse.platform:org.eclipse.core.runtime:jar:3.12.0 -> org.eclipse.platform:org.eclipse.equinox.preferences:jar:3.10.0 -> org.osgi.service:org.osgi.service.prefs:jar:[1.1.0,1.2.0): No versions available for org.osgi.service:org.osgi.service.prefs:jar:[1.1.0,1.2.0) within specified range

The cause is the latest release (v 3.10.0) published yesterday for org.eclipse.platform:org.eclipse.equinox.preferences [1]: in the pom.xml file it declares this dependency:

<dependency>
  <groupId>org.osgi.service</groupId>
  <artifactId>org.osgi.service.prefs</artifactId>
  <version>[1.1.0,1.2.0)</version>
</dependency>

but this dependency doesn't exist in any public Maven repository (at the comment's date, 2022-06-15).
The "closest" Maven artifact to this one seems to be org.osgi:org.osgi.service.prefs (i.e. without .service in the groupId) which is available, with the expected versions [2].

The solution is all about avoiding org.eclipse.platform:org.eclipse.equinox.preferences:3.10.0 artifact from being used, forcing the previous release (i.e. 3.9.100) to be used instead.

[1] https://repo1.maven.org/maven2/org/eclipse/platform/org.eclipse.equinox.preferences/3.10.0/
[2] https://repo1.maven.org/maven2/org/osgi/org.osgi.service.prefs/

@mrizzi mrizzi force-pushed the eclipse-org.osgi.service.prefs-fix branch from ff2649c to 8e7d207 Compare June 15, 2022 09:42
@mrizzi
Copy link
Member Author

mrizzi commented Jun 15, 2022

Commit 6ff860c reverts the changes coming from #1417 because now we're building on JDK 11 so the cause that required those changes (Windup building on JDK 8) is no longer applicable.

Now module windup-eclipse-jdt has these dependencies:

[INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ windup-eclipse-jdt ---
[INFO] org.jboss.windup.jdt:windup-eclipse-jdt:jar:5.3.1-SNAPSHOT
[INFO] +- org.eclipse.jdt:org.eclipse.jdt.core:jar:3.29.0:provided
[INFO] |  +- org.eclipse.platform:org.eclipse.core.resources:jar:3.17.0:provided (version selected from constraint [3.14.0,4.0.0))
[INFO] |  |  \- org.eclipse.platform:org.eclipse.core.expressions:jar:3.8.100:provided (version selected from constraint [3.2.0,4.0.0))
[INFO] |  +- org.eclipse.platform:org.eclipse.core.runtime:jar:3.25.0:provided (version selected from constraint [3.13.0,4.0.0))
[INFO] |  |  +- org.eclipse.platform:org.eclipse.osgi:jar:3.18.0:provided (version selected from constraint [3.17.0,4.0.0))
[INFO] |  |  +- org.eclipse.platform:org.eclipse.equinox.common:jar:3.16.100:provided (version selected from constraint [3.16.0,))
[INFO] |  |  +- org.eclipse.platform:org.eclipse.core.jobs:jar:3.13.0:provided (version selected from constraint [3.13.0,4.0.0))
[INFO] |  |  +- org.eclipse.platform:org.eclipse.equinox.registry:jar:3.11.100:provided (version selected from constraint [3.11.0,4.0.0))
[INFO] |  |  +- org.eclipse.platform:org.eclipse.equinox.preferences:jar:3.9.100:provided
[INFO] |  |  +- org.eclipse.platform:org.eclipse.core.contenttype:jar:3.8.100:provided (version selected from constraint [3.8.0,4.0.0))
[INFO] |  |  \- org.eclipse.platform:org.eclipse.equinox.app:jar:1.6.100:provided (version selected from constraint [1.6.0,))
[INFO] |  +- org.eclipse.platform:org.eclipse.core.filesystem:jar:1.9.400:provided (version selected from constraint [1.7.0,2.0.0))
[INFO] |  \- org.eclipse.platform:org.eclipse.text:jar:3.12.100:provided (version selected from constraint [3.6.0,4.0.0))
[INFO] |     \- org.eclipse.platform:org.eclipse.core.commands:jar:3.10.200:provided (version selected from constraint [3.5.0,4.0.0))

where every Eclipse dependency is inherited but the org.eclipse.platform:org.eclipse.equinox.preferences:3.9.100, required to fix the current build issue.

Copy link
Member Author

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is still affecting our builds so I'm going to merge to get back to normality for builds ASAP.

@mrizzi mrizzi merged commit 41205d4 into windup:master Jun 16, 2022
@mrizzi mrizzi deleted the eclipse-org.osgi.service.prefs-fix branch June 16, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant