[WINDUP-3881]-"Export zip" is not working in Windows #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Windows characters error
mrizzi
added
auto-backport
…example.war (windup#1680) * Changed libs in hibernate-tutorial-web-3.3.2.GA.war and spring-small-example.war * Made windup-rulesets caches uniquely identified * Changed libs in Windup1x-javaee-example.war * Changed libs in jee-example-app-1.0.0.ear * Changed libs in duplicate/duplicate-ear-test-{1,2,3}.ear * Changed libs in frameworks.war * Changed libs in graph/tests/src/test/resources/project_model_traversal/app.ear * Restore MANIFEST.MF in Windup1x-javaee-example.war
…into WINDUP-3881
mrizzi
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Changes have been tested successfully (thanks @PhilipCattanach).
Thanks for fixing this @carlosthe19916
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
* Output URI created from a java.io.File rather than a String to avoid Windows characters error --------- Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> (cherry picked from commit cff9651)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mrizzi
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Output URI created from a java.io.File rather than a String to avoid Windows characters error --------- Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> (cherry picked from commit cff9651) Co-authored-by: Carlos E. Feria Vila <carlosthe19916@gmail.com>
jmle
pushed a commit
to jmle/windup
that referenced
this pull request
Jun 26, 2023
* Output URI created from a java.io.File rather than a String to avoid Windows characters error --------- Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WINDUP-3881
In Windows, the value of
String zipOutputPathis formatted using\as a file separator; however, a URI object should be constructed by a String that uses/as a separator. Creating the final URI object based on ajava.io.Filemakes sure the separators are handled automatically on each OS.