WINDUP-216: Per-ruleset metadata #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Docs on the interface could be a little richer, such as explaining that addons must actually publish a service that implements this interface, not just implement it (when using CDI implementation is enough, but if not, they may need to take additional steps to register it as a furnace service, such as when using the simple container) |
lincolnthree
added a commit
that referenced
this pull request
Aug 19, 2014
WINDUP-216: Per-ruleset metadata
|
I would add that, but I'll have to admit that I have never registered a service with Furnace in a non-CDI addon. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/WINDUP-216