WINDUP-223: Support executeBefore()/executeBeforeIDs() and executeAfter(... #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also covering JIRA: https://issues.jboss.org/browse/WINDUP-160 |
| @@ -130,7 +130,7 @@ private void logTimeTakenByPhase(GraphContext graphContext, RulePhase phase, int | |||
| { | |||
| RulePhaseExecutionStatisticsModel model = graphContext.getService(RulePhaseExecutionStatisticsModel.class) | |||
| .create(); | |||
| model.setRulePhase(phase.toString()); | |||
| model.setRulePhase(phase == null ? "Implicit" : phase.toString()); | |||
There was a problem hiding this comment.
Seems like "Implicit" should be a constant somewhere?
…er()/executeAfterIDs() for provider ordering
|
Ok, switched to using RulePhase.IMPLICIT (instead of null) and also defaulted getPhase() to MIGRATION_RULES. |
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private <T> Class<T> unwrapType(Class<T> wrapped) |
There was a problem hiding this comment.
Is this something new? Why do we need this "now"? Just curious.
There was a problem hiding this comment.
This was there before, but I think in a less clear way.
lincolnthree
added a commit
that referenced
this pull request
Aug 25, 2014
WINDUP-223: Support executeBefore()/executeBeforeIDs() and executeAfter(...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...)/executeAfterIDs() for provider ordering
https://issues.jboss.org/browse/WINDUP-223
Also:
https://issues.jboss.org/browse/WINDUP-160