WINDUP-254 Improve error message in RuleSubset.

[OndraZizka]

The current message misses the original message from the cause exception.

[mbriskar]

+1. That ex.getMessage(); is really needed, the exception itself is not shown in the console output and having only information about which rule failed is not sufficient. As Ondra said, something is not letting exception to get through to output. So this fix is just a workaround, because message itself is shown in the output. The actual fix would be to propagate that exception all the way to console
output.

EDIT: However, after a deeper look inside, not sure if the message would be enough.

[lincolnthree]

When you say the exception is not shown in the console output, what do you mean? Is this the same surefire issue you're talking about?

[lincolnthree]

What about an alternate solution? Simply log the entire message as ERROR: before throwing the new exception? Thoughts?

[OndraZizka]

Output example: http://www.qa.jboss.com/~ozizka/Windup/compar/WindupComparison02/logsW2/WebLogicExamples_wldfdemo-wlnav.war.txt

[OndraZizka]

"log the entire message as ERROR: before throwing the new exception?"

That was exactly the solution that you and Pete rejected in other PR for the case of XML parsing error.

[OndraZizka]

lincolnthree commented 28 days ago

Hiding the root cause basically makes this type of error useless IMO, since you pretty much always need to see the underlying exception to figure out what really happened. IOException "Could not open input stream, etc" is really, "File not found".

#164

[jsight]

I'd like to see an example of what an error looks like with this formatting. I do think that it is important that we surface the root cause like this, though. I'm generally in favor of this.

(although alternatively, it could just be printed to the forge.log as lincoln suggested)

[lincolnthree]

The log is purely a resignation to help you guys debug. I really don't think it should be necessary, but obviously something is wrong with Surefire, so adding an extra log statement isn't the end of the world. If it helps you guys be more productive, I'd rather do that than have you suffer.

[lincolnthree]

So change this to log instead of changing the exception message and we can merge.

[OndraZizka]

Without:

org.jboss.windup.util.exception.WindupException_$$_javassist_489f618e-20fb-4ee3-aa90-4169b4e20304: Error encountered while evaluating rule: .addRule().when(org.jboss.windup.config.query.Query@55b21fe3).perform(org.jboss.windup.config.operation.Iteration@214b9c09) from: org.jboss.windup.reporting.rules.CreateApplicationReportIndexRuleProvider defined in: org.jboss.windup.reporting.rules.CreateApplicationReportIndexRuleProvider.getConfiguration(CreateApplicationReportIndexRuleProvider.java:61)

[OndraZizka]

With:

org.jboss.windup.util.exception.WindupException_$$_javassist_5561f66c-decb-427f-ad36-50bda9eea530:
Error, no project found in source-based input directory: /home/ondra/work/Migration/Windup/rules/app/java/src/test/java/org/jboss/windup/rules/java
Error encountered while evaluating rule: .addRule().when(org.jboss.windup.config.query.Query@765d5902).perform(org.jboss.windup.config.operation.Iteration@6a7ecf03)
From: org.jboss.windup.reporting.rules.CreateApplicationReportIndexRuleProvider
Defined in: org.jboss.windup.reporting.rules.CreateApplicationReportIndexRuleProvider.getConfiguration(CreateApplicationReportIndexRuleProvider.java:61)

I dare to say the new format is more readable. Github removes the formatting. See https://issues.jboss.org/browse/WINDUP-254

[jsight]

Where are you getting that output?

[OndraZizka]

The output is in my branch Branch: WindupProcessor-WINDUP-253