Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUP-329 Bundle settings.xml and a build script #300

Merged
merged 2 commits into from
Oct 16, 2014
Merged

WINDUP-329 Bundle settings.xml and a build script #300

merged 2 commits into from
Oct 16, 2014

Conversation

OndraZizka
Copy link
Contributor

It's more convenient for the user to get the source and run build/build.sh than to follow build instructions and change files manually. There's no manual intervention needed if we make it so.
It will also make tests and CI more convenient - no need to create/edit local settings.xml.

This is how WildFly has it.
Alternatively, we could add the repo to pom.xml - just like JBoss Developer Framework has it now.

@windupgithubbot1
Copy link

Merged build triggered.

@windupgithubbot1
Copy link

Merged build started.

@jsight
Copy link
Member

jsight commented Oct 15, 2014

I think that I like the idea of doing this. However, I noticed that it doesn't appear to do a priming build (-Dskiptests). Perhaps that just needs to be in the documentation?

@windupgithubbot1
Copy link

Merged build finished. Test FAILed.

@windupgithubbot1
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://10.3.9.192//job/windup-pr-builder/31/

Failed Tests: 8

org.jboss.windup.ext:windup-config-groovy: 2

org.jboss.windup.graph:windup-graph-tests: 4

org.jboss.windup.reporting:windup-reporting-tests: 1

org.jboss.windup.rules.apps:rules-java: 1

Test FAILed.

@OndraZizka
Copy link
Contributor Author

retest

@windupgithubbot1
Copy link

Merged build triggered.

@windupgithubbot1
Copy link

Merged build started.

@windupgithubbot1
Copy link

Merged build finished. Test PASSed.

@windupgithubbot1
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://10.3.9.192//job/windup-pr-builder/33/Test PASSed.

@windupgithubbot1
Copy link

Merged build triggered.

@windupgithubbot1
Copy link

Merged build started.

@OndraZizka
Copy link
Contributor Author

I've added the README.txt, and the Linux script determines the need for a priming build automatically.

@windupgithubbot1
Copy link

Merged build triggered.

@OndraZizka OndraZizka force-pushed the BuildScript-WINDUP-329 branch 2 times, most recently from b3ba2f7 to bf85d9e Compare October 16, 2014 13:20
@windupgithubbot1
Copy link

Merged build triggered.

@windupgithubbot1
Copy link

Merged build finished. Test FAILed.

@windupgithubbot1
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://10.3.9.192//job/windup-pr-builder/37/

Failed Tests: 3

org.jboss.windup.graph:windup-graph-tests: 3

Test FAILed.

@windupgithubbot1
Copy link

Merged build started.

@windupgithubbot1
Copy link

Merged build triggered.

@windupgithubbot1
Copy link

Merged build finished. Test PASSed.

@windupgithubbot1
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://10.3.9.192//job/windup-pr-builder/38/Test PASSed.

@windupgithubbot1
Copy link

Merged build started.

@windupgithubbot1
Copy link

Merged build finished. Test PASSed.

@windupgithubbot1
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://10.3.9.192//job/windup-pr-builder/39/Test PASSed.

@windupgithubbot1
Copy link

Merged build started.

@OndraZizka
Copy link
Contributor Author

This is ready to review, not sure why the test was triggered again.

@windupgithubbot1
Copy link

Merged build finished. Test FAILed.

@windupgithubbot1
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://10.3.9.192//job/windup-pr-builder/40/

Failed Tests: 2

org.jboss.windup.config:windup-config-tests: 2

Test FAILed.

lincolnthree added a commit that referenced this pull request Oct 16, 2014
@lincolnthree
Merge pull request #300 from OndraZizka/BuildScript-WINDUP-329
e855d4b 
WINDUP-329  Bundle settings.xml and a build script
@lincolnthree lincolnthree merged commit e855d4b into windup:master Oct 16, 2014
PhilipCattanach pushed a commit to PhilipCattanach/windup that referenced this pull request Feb 20, 2023
@mrizzi @jsight
WINDUPRULE-333 - EAP 7 rules: update target from '[6,8)' to '[7,8)' (w…
47b6678 
…indup#300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@OndraZizka @windupgithubbot1 @jsight @lincolnthree