Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUP-363 --output directory must not be a parent of --input directory ... #329

Closed

Conversation

OndraZizka
Copy link
Contributor

Untested - TBD

@windupgithubbot1
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://10.3.9.192//job/windup-pr-builder/86/Test PASSed.

@jsight
Copy link
Member

jsight commented Oct 23, 2014

This is a good check to have, although, I see two problems at the moment:

  1. I think that you need to call "normalize" before comparing paths like this. toAbsolutePath will still leave "../" sections in the path from what I have seen.
  2. This needs to be implemented in WindupCommand.validate to give the user a validation message, rather than in WindupProcessor, IMO.

@lincolnthree
Copy link
Contributor

I think implementing in both places is fine, but it definitely also needs to be implemented as a UI validation.

@lincolnthree
Copy link
Contributor

Out of date.

PhilipCattanach pushed a commit to PhilipCattanach/windup that referenced this pull request Feb 20, 2023
* WINDUPRULE-344: Started on test generator xslt

* WINDUPRULE-344 enhancements to XSLT and script (windup#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants