Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUP-394 Support default value in WindupConfigurationOption #361

Merged
merged 1 commit into from
Dec 11, 2014
Merged

WINDUP-394 Support default value in WindupConfigurationOption #361

merged 1 commit into from
Dec 11, 2014

Conversation

OndraZizka
Copy link
Contributor

No description provided.

@windupgithubbot1
Copy link

Merged build triggered.

@windupgithubbot1
Copy link

Merged build started.

@windupgithubbot1
Copy link

Merged build finished. Test PASSed.

@windupgithubbot1
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://10.3.9.192//job/windup-pr-builder/206/
Test PASSed.

@jsight
Copy link
Member

jsight commented Nov 26, 2014

I don't see the code to use the default value in this commit? I think some changes to WindupCommand are needed as well?

@OndraZizka
Copy link
Contributor Author

It is possible I didn't include it in the commit, sorry. Will get to it very soon.

@lincolnthree
Copy link
Contributor

Any update on this?

@windupgithubbot1
Copy link

Build triggered.

@OndraZizka
Copy link
Contributor Author

I originally intended to simply use it directly - by calling if(... == null ) ... = getDefaultValue() from the Rule itself. But having it done automatically is nicer. So I added what I think could do it (WindupCommand), although not sure. Perhaps that should be done at Forge level?

@windupgithubbot1
Copy link

Build started.

@windupgithubbot1
Copy link

Build finished. Test PASSed.

@windupgithubbot1
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://10.3.9.192//job/windup-pr-builder/270/
Test PASSed.

lincolnthree
lincolnthree reviewed Dec 10, 2014
View reviewed changes
config/api/src/main/java/org/jboss/windup/config/AbstractWindupConfigurationOption.java
@Override
public Object getDefaultValue()
{
if (Boolean.class.isAssignableFrom(this.getType()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably also want to support "boolean.class"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jsight
Copy link
Member

jsight commented Dec 10, 2014

This looks good to me (it just needs the rebase, IMO).

@OndraZizka
Copy link
Contributor Author

Comments processed and rebased.

@windupgithubbot1
Copy link

Merged build triggered.

@windupgithubbot1
Copy link

Merged build started.

@jsight jsight merged commit d04db33 into windup:master Dec 11, 2014
@windupgithubbot1
Copy link

Merged build finished. Test FAILed.

@windupgithubbot1
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://10.3.9.192//job/windup-pr-builder/288/

Failed Tests: 1

org.jboss.windup.rules.apps:rules-java: 1


Test FAILed.

PhilipCattanach pushed a commit to PhilipCattanach/windup that referenced this pull request Feb 20, 2023
@mrizzi @PhilipCattanach
WINDUPRULE-382 QueryCacheFactory implementations (windup#361)
c21139a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready to Review
Projects
None yet
Milestone
No milestone
4 participants
@OndraZizka @windupgithubbot1 @jsight @lincolnthree