WINDUP-417 WindupRuleProviderSorter - make the error message clearer, shorten #370
Conversation
|
Merged build triggered. |
|
Merged build started. |
|
Merged build triggered. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build started. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
|
||
| private static String formatErrorMessageAfter(WindupRuleProvider provider, WindupRuleProvider otherProvider) | ||
| { | ||
| return "Rule \"" + provider.getID() + "\" from phase \"" + provider.getPhase() + "\" is to set to execute after\n" |
There was a problem hiding this comment.
Replace "Rule" with ---- WindupRuleProvider.class.getSimpleName() + " [" + provider.getID() + "] ... etc
|
Looks good! Could you please rebase to a single commit and add a JIRA issue reference for it? (Create a JIRA if needed.) Thanks! |
OndraZizka
changed the title
|
Done and squashed. |
|
Merged build triggered. |
|
Merged build started. |
|
"add a JIRA issue reference for it" means to the commit msg? Or just PR? |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
This commit needs to reference the JIRA ID. |
|
Still waiting for this commit to be updated. |
|
Merged build triggered. |
|
Done. (I was trying to change the branch connected to this PR, but had to forcePush master) |
…ors at once. Prevents the try-fix-try-fix-try-fix... loop.
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build started. |
|
Merged build finished. Test FAILed. |
|
Test FAILed. Failed Tests: 1org.jboss.windup.config:windup-config-tests: 1Test FAILed. |
|
Looks good now. Thanks. |
WINDUP-417 WindupRuleProviderSorter - make the error message clearer, shorten
* windup-2203 added rules , tests and 2 test files * windup-2203 added more info on test files, and tweaked a bit the rule * windup-2203 fixed typo on the rule test for JACC * windup-2203 added rules and tests for Servlet and JSON-B * windup-2203 added test file * windup-2203 added iterable-filter to the rule tests in order to explicitly check the number of ocurrences * windup-2203 [PR] fixed typo
To squash or not to squash? You might like only some parts of these changes. Will squash if ok to merge.