WINDUP-447: NPE halts Windup execution #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no unit test as I was unable to reproduce the issue. However, the code below logs a warning in this case and allows execution to proceed.
|
Merged build triggered. |
1 similar comment
|
Merged build triggered. |
| @@ -60,6 +60,10 @@ public Object exec(@SuppressWarnings("rawtypes") List arguments) throws Template | |||
| throw new TemplateModelException("Error, method expects one argument (ProjectModel)"); | |||
| } | |||
| StringModel stringModelArg = (StringModel) arguments.get(0); | |||
| if (stringModelArg == null) | |||
| { | |||
| throw new IllegalArgumentException("FreeMarker Method " + NAME + " called with null project model"); | |||
There was a problem hiding this comment.
Should this print which template this was found in?
There was a problem hiding this comment.
That would be great, but I don't think I have any way of knowing that. :(
lincolnthree
added a commit
that referenced
this pull request
Jan 15, 2015
WINDUP-447: NPE halts Windup execution
|
Merged build started. |
|
Merged build finished. Test FAILed. |
|
Test FAILed. |
PhilipCattanach
pushed a commit
to PhilipCattanach/windup
that referenced
this pull request
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/WINDUP-447