Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUP-680: Java API Incorrectly Processes Interfaces & WINDUP-681: J… #624

Merged
merged 1 commit into from Jul 13, 2015
Merged

WINDUP-680: Java API Incorrectly Processes Interfaces & WINDUP-681: J… #624

merged 1 commit into from Jul 13, 2015

Conversation

jsight
Copy link
Member

@jsight jsight commented Jun 30, 2015

…ava API Should Provide Marker for Type: Interface, Class

mbriskar
mbriskar reviewed Jul 3, 2015
View reviewed changes
java-ast/tests/src/test/java/org/jboss/windup/ast/java/test/JavaASTReferenceResolverTest.java
Paths.get("src/test/resources/testclasses/simple/EventServer.java"));
for (ClassReference reference : references)
{
System.out.println("Reference: " + reference);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a debug println and should be probably removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are useful for debugging tests, but I'll remove them anyway :)

@jsight jsight force-pushed the WINDUP-680 branch 3 times, most recently from 36801b4 to 8c39b6e Compare July 7, 2015 18:58
@jsight jsight closed this Jul 7, 2015
@jsight jsight reopened this Jul 7, 2015
@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/286/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/919/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/289/

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1


Test FAILed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/921/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/291/
Test PASSed.

@jsight
WINDUP-680: Java API Incorrectly Processes Interfaces & WINDUP-681: J…
c27e21e 
…ava API Should Provide Marker for Type: Interface, Class
@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/933/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/303/

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1


Test FAILed.

lincolnthree added a commit that referenced this pull request Jul 13, 2015
@lincolnthree
Merge pull request #624 from jsight/WINDUP-680
4f6229d 
WINDUP-680: Java API Incorrectly Processes Interfaces & WINDUP-681: J…
@lincolnthree lincolnthree merged commit 4f6229d into windup:master Jul 13, 2015
PhilipCattanach pushed a commit to PhilipCattanach/windup that referenced this pull request Feb 20, 2023
@jmle
[WINDUP-782] Reword rule message (windup#624)
17ac711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jsight @windupgithubbot1 @lincolnthree @mbriskar