Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUP-685: Inappropriate output directory selection in some cases #625

Merged
merged 1 commit into from Jul 6, 2015

Conversation

jsight
Copy link
Member

@jsight jsight commented Jun 30, 2015

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/901/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/270/
Test PASSed.

* This could be the same directory as the file itself, if the file is already in the output directory. If the .class file is referencing a file
* in the input directory, then this will be a classes folder underneath the output directory.
*/
static File getOutputDirectoryForClass(GraphContext context, JavaClassFileModel fileModel)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I would state in the documentation that this is only the top-directory path (without package)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. thanks

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/912/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/281/
Test PASSed.

lincolnthree added a commit that referenced this pull request Jul 6, 2015
WINDUP-685: Inappropriate output directory selection in some cases
@lincolnthree lincolnthree merged commit ec55cc3 into windup:master Jul 6, 2015
PhilipCattanach added a commit to PhilipCattanach/windup that referenced this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants