WINDUP-670: Make Rexster more convenient to use #628
Conversation
|
It will work after the furnace new version will be released with the patch. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| </dependency> | ||
| <groupId>org.jboss.windup</groupId> | ||
| <artifactId>arquillian</artifactId> | ||
| <version>${project.version}</version> |
There was a problem hiding this comment.
note that this is not a forge addon
There was a problem hiding this comment.
maybe this should be renamed to "windup-test-harness" instead of "arquillian" ?
| @Override public List<DeploymentDescription> enhance(TestClass testClass, List<DeploymentDescription> deployments) | ||
| { | ||
| String debugProperty = System.getProperty("maven.surefire.debug"); | ||
| if(Boolean.getBoolean(debugProperty)) { |
There was a problem hiding this comment.
This should be if(Boolean.getBoolean("maven.surefire.debug"))
| * Tests that rexster is properly deployed thanks to Arquillian ad | ||
| */ | ||
| @RunWith(Arquillian.class) | ||
| public class RexsterDefaultDeploymentTest |
There was a problem hiding this comment.
This is the test testing that it is deployed when surefire debug is ON
mbriskar
force-pushed
the
WINDUP-670
branch
2 times, most recently
from
e4b1bb3
to
cdb8891
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest please |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
problem is on my side, fixing immediately |
mbriskar
force-pushed
the
WINDUP-670
branch
2 times, most recently
from
ea2d83d
to
39d6513
Compare
|
hopefully fixed. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1org.jboss.windup.rules:windup-rulesets: 1Test FAILed. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1org.jboss.windup.rules:windup-rulesets: 1Test FAILed. |
| <scope>test</scope> | ||
| </dependency> | ||
| <groupId>org.jboss.windup</groupId> | ||
| <artifactId>windup-test-harness</artifactId> |
|
@lincolnthree what about the failing tests in rulesets? Or didn't this PR cause it? |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1org.jboss.windup.rules:windup-rulesets: 1Test FAILed. |
|
I don't think this PR caused it. |
WINDUP-670: Make Rexster more convenient to use
From now on, rexster is deployed by default everytime you debug within windup.