Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle tags windup 679 #633

Merged
merged 1 commit into from Jul 20, 2015
Merged

Handle tags windup 679 #633

merged 1 commit into from Jul 20, 2015

Conversation

OndraZizka
Copy link
Contributor

For now, it is storing the tags in @SetInProperties.
What's new:

  • tags added to InlineHint and Classification;
  • handled for and
  • Tags appear in the report next to TechnologyTags for the files
  • Test added for those

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/299/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/929/
Test PASSed.

@OndraZizka OndraZizka force-pushed the handleTags-WINDUP-679 branch 2 times, most recently from f397ea6 to 69f1b55 Compare July 14, 2015 14:32
@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/942/

Failed Tests: 89

org.jboss.windup:windup-tooling-tests: 1

org.jboss.windup.config:windup-config-tests: 19

org.jboss.windup.reporting:windup-reporting-tests: 7

org.jboss.windup.rules.apps:windup-rules-base-tests: 2

org.jboss.windup.rules.apps:windup-rules-java-archives-tests: 2

org.jboss.windup.rules.apps:windup-rules-java-ee-tests: 6

org.jboss.windup.rules.apps:windup-rules-java-project-tests: 1

org.jboss.windup.rules.apps:windup-rules-java-tests: 19

org.jboss.windup.rules.apps:windup-rules-xml-tests: 12

org.jboss.windup.tests:windup-tests: 13

org.jboss.windup.ui:windup-ui-tests: 7


Test FAILed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/312/

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1


Test FAILed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/944/

Failed Tests: 89

org.jboss.windup:windup-tooling-tests: 1

org.jboss.windup.config:windup-config-tests: 19

org.jboss.windup.reporting:windup-reporting-tests: 7

org.jboss.windup.rules.apps:windup-rules-base-tests: 2

org.jboss.windup.rules.apps:windup-rules-java-archives-tests: 2

org.jboss.windup.rules.apps:windup-rules-java-ee-tests: 6

org.jboss.windup.rules.apps:windup-rules-java-project-tests: 1

org.jboss.windup.rules.apps:windup-rules-java-tests: 19

org.jboss.windup.rules.apps:windup-rules-xml-tests: 12

org.jboss.windup.tests:windup-tests: 13

org.jboss.windup.ui:windup-ui-tests: 7


Test FAILed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/314/

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1


Test FAILed.

gastaldi
gastaldi reviewed Jul 15, 2015
View reviewed changes
reporting/api/src/main/java/org/jboss/windup/reporting/config/Hint.java
@@ -178,6 +190,11 @@ public int getEffort()
return links;
}

public Set<String> getTags()
{
return UnmodifiableSet.decorate(tags);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use apache-commons, when you have

java.util.Collections.unmodifiableSet(Set<? extends T>)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, fixed

@OndraZizka OndraZizka force-pushed the handleTags-WINDUP-679 branch 2 times, most recently from bf82d0b to 0cc276a Compare July 16, 2015 02:08
@OndraZizka OndraZizka force-pushed the handleTags-WINDUP-679 branch 2 times, most recently from 2ce34d6 to 7fc2298 Compare July 16, 2015 03:24
@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/946/
Test FAILed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/316/
Test FAILed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/949/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/319/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/950/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/320/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/951/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/321/

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1


Test FAILed.

@lincolnthree lincolnthree merged commit 82720a5 into windup:master Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@OndraZizka @windupgithubbot1 @gastaldi @lincolnthree