Fix update rulesets - WINDUP-701 #643

OndraZizka · 2015-07-25T18:32:14Z

I refactored the whole code and made the tests to work, and now I am going to check how it works practically.

The command will be removed. Instead it will be --updateRulesets, handled either in Bootstrap or as an ConfigurationOption and a rule, if that works.

I had to add this to the windup-ui-tests POM to prevent CNFEx,
but it's wrong since threre already is this one with forge-addon, only as provided which is then not picked up in tests (despite @AddonDependency(name = "org.jboss.forge.addon:maven") .)

    <!-- Trying to prevent windup-ui-tests throwing CNFEx with class from org.jboss.forge.addon:maven -->
    <dependency>
        <groupId>org.jboss.forge.addon</groupId>
        <artifactId>maven</artifactId>
        <version>2.16.2.Final</version>
        <scope>test</scope>
    </dependency>

windupgithubbot1 · 2015-07-25T18:52:55Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/331/
Test PASSed.

windupgithubbot1 · 2015-07-25T20:36:56Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/960/

Failed Tests: 1

org.jboss.windup.ui:windup-ui-tests: 1

org.jboss.windup.addon.ui.WindupUpdateDistributionCommandTest.testUpdateDistributionCommand

Test FAILed.

OndraZizka · 2015-07-27T14:42:05Z

Currently I am hitting
java.lang.NoClassDefFoundError: org/jboss/forge/addon/maven/resources/MavenModelResource
And I don't know how to make that class available.

windupgithubbot1 · 2015-07-27T17:15:29Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/334/
Test PASSed.

windupgithubbot1 · 2015-07-27T19:01:27Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/963/

Failed Tests: 1

org.jboss.windup.ui:windup-ui-tests: 1

org.jboss.windup.addon.ui.WindupUpdateDistributionCommandTest.testUpdateDistributionCommand

Test FAILed.

windupgithubbot1 · 2015-07-28T00:43:43Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/337/
Test PASSed.

windupgithubbot1 · 2015-07-28T02:15:35Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/966/

Failed Tests: 5

org.jboss.windup.ui:windup-ui-tests: 5

Test FAILed.

windupgithubbot1 · 2015-07-28T04:30:34Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/967/
Test PASSed.

windupgithubbot1 · 2015-07-28T04:48:31Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/338/
Test PASSed.

mbriskar · 2015-07-29T06:51:33Z

ui/addon/src/main/java/org/jboss/windup/ui/DistributionUpdater.java

+
+            FileUtils.deleteDirectory(addonsDir.toFile());
+            FileUtils.deleteDirectory(libDir.toFile());
+            FileUtils.deleteDirectory(binDir.toFile());


I think these line will not work for Windows because Windows will not let you remove files that are in use or am I wrong?

windupgithubbot1 · 2015-07-29T07:11:04Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/969/

Failed Tests: 4

org.jboss.windup.reporting:windup-reporting-tests: 1

org.jboss.windup.reporting.CSVExportingTest.testCSVExportGeneration

org.jboss.windup.tests:windup-tests: 2

org.jboss.windup.ui:windup-ui-tests: 1

org.jboss.windup.addon.ui.WindupUpdateDistributionCommandTest.testUpdateDistribution

Test FAILed.

windupgithubbot1 · 2015-07-29T07:30:07Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/340/

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1

org.jboss.windup.rules.tests.WindupRulesTest.testWindupRules

Test FAILed.

windupgithubbot1 · 2015-07-29T09:03:51Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/970/

Failed Tests: 2

org.jboss.windup.tests:windup-tests: 2

Test FAILed.

windupgithubbot1 · 2015-07-29T11:00:38Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/341/

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1

org.jboss.windup.rules.tests.WindupRulesTest.testWindupRules

Test FAILed.

OndraZizka · 2015-07-29T14:52:34Z

Locally the tests all pass.

windupgithubbot1 · 2015-07-29T15:08:34Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/972/

Failed Tests: 3

org.jboss.windup.reporting:windup-reporting-tests: 1

org.jboss.windup.reporting.CSVExportingTest.testCSVExportGeneration

org.jboss.windup.tests:windup-tests: 2

Test FAILed.

windupgithubbot1 · 2015-07-29T15:25:53Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/343/

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1

org.jboss.windup.rules.tests.WindupRulesTest.testWindupRules

Test FAILed.

OndraZizka · 2015-07-29T21:51:41Z

The tests pass locally.

jsight · 2015-07-29T21:52:05Z

retest

windupgithubbot1 · 2015-07-29T22:10:44Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/344/

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1

org.jboss.windup.rules.tests.WindupRulesTest.testWindupRules

Test FAILed.

windupgithubbot1 · 2015-07-29T23:49:15Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/973/
Test PASSed.

windupgithubbot1 · 2015-07-30T12:54:30Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/974/
Test PASSed.

windupgithubbot1 · 2015-07-30T13:12:23Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/345/
Test PASSed.

WINDUP-705 Fix automatic distribution updating - partial (shares some code with 701)

OndraZizka · 2015-07-30T15:15:42Z

Squashed

windupgithubbot1 · 2015-07-30T15:17:16Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/975/
Test PASSed.

windupgithubbot1 · 2015-07-30T15:35:28Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/346/

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1

org.jboss.windup.rules.tests.WindupRulesTest.testWindupRules

Test FAILed.

lincolnthree · 2015-07-30T15:36:57Z

bootstrap/src/main/java/org/jboss/windup/bootstrap/Bootstrap.java

@@ -258,31 +257,32 @@ else if ("--generateCompletionData".equals(arg))
            furnaceService.getFurnace().addRepository(AddonRepositoryMode.MUTABLE, new File(getUserWindupDir(), "addons"));
        }

+        if (command == null && updateRulesets && onlyRulesetsUpdateRequested(arguments))


What happens if --updateRulesets is specified in addition to windup execution/analysis information? It currently looks like it will skip the ruleset update silently. That doesn't seem right.

It seems like we probably need to be able to do both comments (e.g. allow multiple commands to be executed based on CLI values supplied.)

windupgithubbot1 · 2015-07-30T17:05:12Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/976/
Test PASSed.

windupgithubbot1 · 2015-07-30T17:22:26Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/347/
Test PASSed.

windupgithubbot1 · 2015-07-30T19:02:38Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/977/
Test PASSed.

windupgithubbot1 · 2015-07-30T19:20:38Z

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/348/
Test PASSed.

OndraZizka · 2015-08-03T13:52:34Z

Maybe I could move the RulesetsUpdater and DistributionUpdater to the same addon. And maybe join them to one class.

lincolnthree · 2015-08-03T22:03:04Z

Closed in favor of PR that includes this commit.

…in hint as a parameterized section (windup#643)

OndraZizka added the Work in Progress/For Discussion Only label Jul 25, 2015

OndraZizka force-pushed the fixUpdateRulesets-WINDUP-701 branch from 549b344 to 5566774 Compare July 27, 2015 14:41

OndraZizka force-pushed the fixUpdateRulesets-WINDUP-701 branch from 1a89b1c to fffaabd Compare July 28, 2015 02:44

OndraZizka force-pushed the fixUpdateRulesets-WINDUP-701 branch from 2b5c916 to 8596fd2 Compare July 29, 2015 06:26

mbriskar reviewed Jul 29, 2015
View reviewed changes

OndraZizka force-pushed the fixUpdateRulesets-WINDUP-701 branch from 3c26abf to ca77162 Compare July 30, 2015 11:14

OndraZizka force-pushed the fixUpdateRulesets-WINDUP-701 branch from 81114f6 to 87b2006 Compare July 30, 2015 13:46

OndraZizka added Reviewed/Ready to Merge and removed Work in Progress/For Discussion Only labels Jul 30, 2015

WINDUP-701 Fix automatic rulesets updating

a7ce016

WINDUP-705 Fix automatic distribution updating - partial (shares some code with 701)

OndraZizka force-pushed the fixUpdateRulesets-WINDUP-701 branch from 87b2006 to a7ce016 Compare July 30, 2015 15:15

lincolnthree reviewed Jul 30, 2015
View reviewed changes

lincolnthree added Ready to Review and removed Reviewed/Ready to Merge labels Aug 3, 2015

lincolnthree closed this Aug 3, 2015

PhilipCattanach pushed a commit to PhilipCattanach/windup that referenced this pull request Feb 20, 2023

WINDUPRULE-830: fix problem with mistakenly identifying code snippet …

6124cc8

…in hint as a parameterized section (windup#643)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix update rulesets - WINDUP-701 #643

Fix update rulesets - WINDUP-701 #643

OndraZizka commented Jul 25, 2015

windupgithubbot1 commented Jul 25, 2015

windupgithubbot1 commented Jul 25, 2015

OndraZizka commented Jul 27, 2015

windupgithubbot1 commented Jul 27, 2015

windupgithubbot1 commented Jul 27, 2015

windupgithubbot1 commented Jul 28, 2015

windupgithubbot1 commented Jul 28, 2015

windupgithubbot1 commented Jul 28, 2015

windupgithubbot1 commented Jul 28, 2015

mbriskar Jul 29, 2015

windupgithubbot1 commented Jul 29, 2015

windupgithubbot1 commented Jul 29, 2015

windupgithubbot1 commented Jul 29, 2015

windupgithubbot1 commented Jul 29, 2015

OndraZizka commented Jul 29, 2015

windupgithubbot1 commented Jul 29, 2015

windupgithubbot1 commented Jul 29, 2015

OndraZizka commented Jul 29, 2015

jsight commented Jul 29, 2015

windupgithubbot1 commented Jul 29, 2015

windupgithubbot1 commented Jul 29, 2015

windupgithubbot1 commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

OndraZizka commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

lincolnthree Jul 30, 2015

lincolnthree Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

OndraZizka commented Aug 3, 2015

lincolnthree commented Aug 3, 2015

Fix update rulesets - WINDUP-701 #643

Fix update rulesets - WINDUP-701 #643

Conversation

OndraZizka commented Jul 25, 2015

windupgithubbot1 commented Jul 25, 2015

windupgithubbot1 commented Jul 25, 2015

Failed Tests: 1

org.jboss.windup.ui:windup-ui-tests: 1

OndraZizka commented Jul 27, 2015

windupgithubbot1 commented Jul 27, 2015

windupgithubbot1 commented Jul 27, 2015

Failed Tests: 1

org.jboss.windup.ui:windup-ui-tests: 1

windupgithubbot1 commented Jul 28, 2015

windupgithubbot1 commented Jul 28, 2015

Failed Tests: 5

org.jboss.windup.ui:windup-ui-tests: 5

windupgithubbot1 commented Jul 28, 2015

windupgithubbot1 commented Jul 28, 2015

mbriskar Jul 29, 2015

Choose a reason for hiding this comment

windupgithubbot1 commented Jul 29, 2015

Failed Tests: 4

org.jboss.windup.reporting:windup-reporting-tests: 1

org.jboss.windup.tests:windup-tests: 2

org.jboss.windup.ui:windup-ui-tests: 1

windupgithubbot1 commented Jul 29, 2015

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1

windupgithubbot1 commented Jul 29, 2015

Failed Tests: 2

org.jboss.windup.tests:windup-tests: 2

windupgithubbot1 commented Jul 29, 2015

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1

OndraZizka commented Jul 29, 2015

windupgithubbot1 commented Jul 29, 2015

Failed Tests: 3

org.jboss.windup.reporting:windup-reporting-tests: 1

org.jboss.windup.tests:windup-tests: 2

windupgithubbot1 commented Jul 29, 2015

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1

OndraZizka commented Jul 29, 2015

jsight commented Jul 29, 2015

windupgithubbot1 commented Jul 29, 2015

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1

windupgithubbot1 commented Jul 29, 2015

windupgithubbot1 commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

OndraZizka commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

Failed Tests: 1

org.jboss.windup.rules:windup-rulesets: 1

lincolnthree Jul 30, 2015

Choose a reason for hiding this comment

lincolnthree Jul 30, 2015

Choose a reason for hiding this comment

windupgithubbot1 commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

windupgithubbot1 commented Jul 30, 2015

OndraZizka commented Aug 3, 2015

lincolnthree commented Aug 3, 2015