Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUP-766: Scan JSP's for potential migration issues #697

Merged
merged 1 commit into from Oct 1, 2015

Conversation

jsight
Copy link
Member

@jsight jsight commented Sep 24, 2015

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/435/
Test PASSed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/1065/
Test PASSed.

JavaClassModel classModel = javaClassService.create();
classModel.setPackageName("");
classModel.setSimpleName(sourceFile.getFileName());
classModel.setQualifiedName(sourceFile.getFileName());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple/qualified name are the same?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as the package name is marked as empty. It's a bit of a hack as it is hard to know what the generated package name will really be.

@mbriskar
Copy link
Contributor

mbriskar commented Oct 1, 2015

I think this is really good and big step forward. I even think it can be improved by providing .xsd change and ideally maybe one test in windup.xml format also.

@jsight
Copy link
Member Author

jsight commented Oct 1, 2015

Why would the xsd need to change?

jsight added a commit that referenced this pull request Oct 1, 2015
WINDUP-766: Scan JSP's for potential migration issues
@jsight jsight merged commit d6ec6e2 into windup:master Oct 1, 2015
@jsight jsight deleted the WINDUP-766 branch October 1, 2015 15:23
@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-core-PR-dependents-check/446/
Test FAILed.

@windupgithubbot1
Copy link

Refer to this link for build results (access rights to CI server needed):
http://10.3.8.5//job/windup-pr-builder/1078/
Test FAILed.

PhilipCattanach pushed a commit to PhilipCattanach/windup that referenced this pull request Feb 20, 2023
* Added rule and basic test

* Fix typo in test

* Rename files, expand message, fix assertion

* Fix typo in message

* Replace tabs with 4 spaces

* Add the -test suffix to the test rule ID

* eap is a source technology

* Renamed class

* update addon dependency, use CDATA in message

* Use aka.ms shortcuts to the documentation

* Renamed directory to Azure

* Fix ruletest id, data path

* Addressed PR feedback, changed newlines to LF

Co-authored-by: Denis Fuenzalida 🐙 <Denis.Fuenzalida@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants