New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WINDUP-766: Scan JSP's for potential migration issues #697
Conversation
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
JavaClassModel classModel = javaClassService.create(); | ||
classModel.setPackageName(""); | ||
classModel.setSimpleName(sourceFile.getFileName()); | ||
classModel.setQualifiedName(sourceFile.getFileName()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple/qualified name are the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as the package name is marked as empty. It's a bit of a hack as it is hard to know what the generated package name will really be.
I think this is really good and big step forward. I even think it can be improved by providing .xsd change and ideally maybe one test in windup.xml format also. |
Why would the xsd need to change? |
WINDUP-766: Scan JSP's for potential migration issues
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
* Added rule and basic test * Fix typo in test * Rename files, expand message, fix assertion * Fix typo in message * Replace tabs with 4 spaces * Add the -test suffix to the test rule ID * eap is a source technology * Renamed class * update addon dependency, use CDATA in message * Use aka.ms shortcuts to the documentation * Renamed directory to Azure * Fix ruletest id, data path * Addressed PR feedback, changed newlines to LF Co-authored-by: Denis Fuenzalida 🐙 <Denis.Fuenzalida@microsoft.com>
https://issues.jboss.org/browse/WINDUP-766