WINDUP-812 Cache classification vertex lookups from the graph #735
Conversation
OndraZizka
force-pushed
the
cacheClsfLookups-WINDUP-812
branch
from
4a2dbaa
to
674a2a6
Compare
|
retest |
|
Build triggered. sha1 is merged. |
|
Build started sha1 is merged. |
|
Build triggered. sha1 is merged. |
|
Build finished. No test results found. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Build started sha1 is merged. |
|
Build finished. No test results found. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Have you seen any performance improvements from this? |
|
Haven't tried yet, I think this could get us some on larger apps which will take me some time to get to. So, currently "for discussion only" :) |
|
Testing |
|
It ran slightly faster. On a large app, it was from cca 136 minutes hours down to 135. :) I have only tested it once. |
OndraZizka
force-pushed
the
cacheClsfLookups-WINDUP-812
branch
from
674a2a6
to
7f855f1
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
OndraZizka
force-pushed
the
cacheClsfLookups-WINDUP-812
branch
from
7f855f1
to
2eb263e
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
OndraZizka
force-pushed
the
cacheClsfLookups-WINDUP-812
branch
from
2eb263e
to
f978523
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
The Map itself is not static, so the cache would only be used in cases where we cache the ClassificationService itself. I can't think of very many cases when we do that. In its current form, I don't think this PR can actually improve performance to a measurable degree. |
An untested attempt