WINDUP-997: spring-mvc.xml as invalid by 'XML File is not valid' rule #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sourceFile.setGenerateSourceReport(true); | ||
|
|
||
| ClassificationService classificationService = new ClassificationService(event.getGraphContext()); | ||
| ClassificationModel model =classificationService.attachClassification(context, sourceFile, XmlFileModel.NOT_VALID_XML, |
|
We have the Unparsable files report, does this count with it? I know that if it doesn't, the original did not either, but once on it, we should add it to the unparsables. |
|
I don't think we have generally treated a xsd validation error as "unparsable". In many cases these files are actually valid and working within their context, which isn't really the same as unparsable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/WINDUP-997