Fix: Pin Faraday dependency so that this gem still supports older versions of Ruby. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby. - Bump version to 0.2.5 - Pin to 0.14.0 as 0.15.x breaks the tests and 0.16.x only supports Ruby 2.3.0 and above.
|
Thank you! 😃 |
|
Thanks @winebarrel and @treacher ! When will the new gem be released? Cheers |
|
v0.2.5 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have I changed?
2.3.0 and above.
core/instance_profile_credentials.rb#L81
Testing done
Ran the rspec tests locally.
Why are you making this change?
We currently have a lot of our production instances relying on this Gem. The instances are currently running Ruby 2.2. Faradays latest release has essentially dropped support for versions of ruby less than 2.3. I'm hoping to have this change merged to reduce the impact of the Faraday change on the consumers of this gem.