Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tim-sort.md #272

Merged
merged 9 commits into from
Oct 20, 2022
Merged

Update tim-sort.md #272

merged 9 commits into from
Oct 20, 2022

Conversation

Bobliuuu
Copy link
Contributor

@Bobliuuu Bobliuuu commented Oct 15, 2022

Change Summary

Closes issue #103

Checklist

Ideally all of them should be checked. If you haven't fulfilled the below requirements or even delete the entire checklist, your PR won't be reviewed.

General

  • Make sure you've read CONTRIBUTING.md
  • Make sure you've followed the template format
  • Make sure you've started the app locally and verified all the content and all links (if applicable) must be accessible correctly
  • Make sure you've applied LaTex for variables, formulas and time / space complexity instead of using backticks
  • Make sure you've formatted your code well (Code Block is rendered using <Tabs/>)
    Below is a C++ example. You can include multiple langs using <TabItem/> if necessary
<Tabs>

<TabItem value="cpp" label="C++">
<SolutionAuthor name="@YOUR_ALIAS"/>

```cpp
// Your code goes here
// Prefer K&R Coding style
// See https://gist.github.com/jesseschalken/0f47a2b5a738ced9c845#why-kr for example
```

</TabItem>

</Tabs>
  • Make sure you've explained your code well (write comments above each line - not inline)
  • Make sure you've written your explanation well and it is easy to understand for beginners
  • Make sure you've included Time & Space Complexity Analysis
  • Make sure you've included a meaningful approach name for your solution. Don't leave it blank. e.g. ## Approach 1: Two Pointers.

For Tutorial Articles

  • Make sure you've explained your topic using 1 - 3 LC problems rather than using external problems. Solutions must be taken with explanations as well.
  • Make sure you've provided suggested problems at the end using the given format. See here as an example. If the target solution is not available, leave solutionLink blank.
  • Make sure you've given credits / references if you use external resources. For an image, give credit under it. Otherwise, add a new section called References at the end (after Suggested Problems).

Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall it looks good. just a few comments.

tutorials/basic-topics/sorting/tim-sort.md Outdated Show resolved Hide resolved
tutorials/basic-topics/sorting/tim-sort.md Outdated Show resolved Hide resolved
tutorials/basic-topics/sorting/tim-sort.md Show resolved Hide resolved
tutorials/basic-topics/sorting/tim-sort.md Outdated Show resolved Hide resolved
tutorials/basic-topics/sorting/tim-sort.md Outdated Show resolved Hide resolved
tutorials/basic-topics/sorting/tim-sort.md Outdated Show resolved Hide resolved
@wingkwong wingkwong added the Status: Pending for Changes The PR is reviewed with some changes requested. Waiting for contributors' actions. label Oct 16, 2022
@wingkwong wingkwong added Status: Pending for Review The PR is ready and waiting for reviewers to review and removed Status: Pending for Changes The PR is reviewed with some changes requested. Waiting for contributors' actions. labels Oct 16, 2022
<SolutionAuthor name="@Bobliuuu"/>

```cpp
class Solution {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy this solution and run on LC. It shows Compile Error. Please update it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wingkwong, it doesn't show compile error for me.
image

@wingkwong wingkwong added Status: Pending for Changes The PR is reviewed with some changes requested. Waiting for contributors' actions. and removed Status: Pending for Review The PR is ready and waiting for reviewers to review labels Oct 19, 2022
@Bobliuuu
Copy link
Contributor Author

Hi @wingkwong, I updated the problem!

@wingkwong wingkwong added Status: Pending for Review The PR is ready and waiting for reviewers to review and removed Status: Pending for Changes The PR is reviewed with some changes requested. Waiting for contributors' actions. labels Oct 20, 2022
Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up a bit.

@wingkwong wingkwong merged commit 4dd196a into wingkwong:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending for Review The PR is ready and waiting for reviewers to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants