Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): concat strings with + #2429

Merged
merged 4 commits into from
May 7, 2023
Merged

feat(compiler): concat strings with + #2429

merged 4 commits into from
May 7, 2023

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented May 7, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner May 7, 2023 09:10
@mergify
Copy link
Contributor

mergify bot commented May 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e36c71e into main May 7, 2023
11 checks passed
@mergify mergify bot deleted the rybickic/plus-strings branch May 7, 2023 13:07
@mergify
Copy link
Contributor

mergify bot commented May 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.15.24.

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -1161,38 +1161,24 @@ exports[`try_no_catch_or_finally.w > stderr 1`] = `
`;

exports[`types_strings_arithmetic.w > stderr 1`] = `
"error: Expected type to be \\"num\\", but got \\"str\\" instead
"error: Binary operator '+' cannot be applied to operands of type 'num' and 'str'; only (num, num) and (str, str) are supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants