New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platforms): support platform parameters #5557
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-5557.fly.dev 🚀 Last Updated (UTC) 2024-02-08 02:28 |
BenchmarksComparison to Baseline ⬜⬜🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-02-08 02:34 |
4e9135c
to
6ac4e62
Compare
@eladb I went down the intermediate step of defining platform parameters in Jsonschema. Let me know what you think. I still need to update the platform docs, but I figured I would wait until I get some thoughts about the design, and if it makes sense to keep things this way. |
@marciocadev I also requested your review incase you want to see any of these changes (since you built the initial platform specific code) |
Man, I don't even know what to say, the use of json-schema to create the required parameters was brilliant I love it ❤️❤️❤️ |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Co-authored-by: Marcio Cruz de Almeida <67694075+marciocadev@users.noreply.github.com>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it
f908588
to
2f99c55
Compare
Signed-off-by: monada-bot[bot] <monabot@monada.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really well done! I've added some minor comments, but it looks solid overall to me :-)
Thanks for contributing, @hasanaburayyan! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.57.13. |
This PR introduces has two main changes:
tf-aws
platform that will now allow users to specify their ownvpc
when creating resources that need to be deployed behind a vpc (right now just redis)Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.