fix(compiler): lifting globals from inflight classes defined in preflight fails #5559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoav-steinberg
changed the title
|
Thanks for opening this pull request! 🎉
|
|
Console preview environment is available at https://wing-console-pr-5559.fly.dev 🚀 Last Updated (UTC) 2024-06-27 11:59 |
BenchmarksComparison to Baseline ⬜🟥⬜⬜⬜🟥⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-06-27 12:05 |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
yoav-steinberg
changed the title
…nglang/wing into yoav/qualify_err_closure_lift
(inflight closures transformation now produces an inflight class)
Chriscbr
reviewed
Feb 7, 2024
…LifeableModuleType`
Because the type system can't distinguish between a closure class (which needs to be lifted) and a regular function type... Also lift on reference and not all call, by assuming a ref to a closure will actually call it later on, we can correctly lift (and setup permissions) for closures stored in collections (for example). This is a special exception to our qualification rules, since closures only have a single method (`handle`) so we can implicitly qualify it.
so we're sure the type is lifted
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Chriscbr
approved these changes
Jun 26, 2024
tools/hangar/__snapshots__/test_corpus/valid/bring_local.test.w_compile_tf-aws.md
Outdated
Show resolved
Hide resolved
Chriscbr
removed
the
⚠️ pr/review-mutation
Co-authored-by: Chris Rybicki <chrisr@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
…nglang/wing into yoav/qualify_err_closure_lift
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
…nglang/wing into yoav/qualify_err_closure_lift
MarkMcCulloh
removed
the
⚠️ pr/review-mutation
|
Thanks for contributing, @yoav-steinberg! This PR will now be added to the merge queue, or immediately merged if |
|
Congrats! 🚀 This was released in Wing 0.75.15. |
Merged
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2024
…ight fails, take 2 (#6801) This is a resubmit of #5559 with the following fix: The `bringJs` helper function merges the brought module's type map into the bringing module's type map. During this merge there's a safety check to verify we don't overwrite one type over another if they have the same uids (should never happen). In reality there are cases where the same type in brought twice (two different files include the same .w file). I now detect these cases and ignore them in the safety check. Also added a test for this. ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2730
The wing compiler always generated dummy preflight classes for inflight classes defined preflight. This means such inflight classes have a lift map and therefore already include all the lift qualification information needed when their mehtods are used inflight. The problem was that our lift visitor ignored references to such classes because it looks for preflight expressions to lift, but references to inflight classes aren't preflight expressions.
This PR finds such references and creates a special lift with correct qualifications using dummy singleton preflight object representing the relevant inflight class. To get this working the following changes where made:
Resourceclass has a satatic_singleton()method_singleton()method to get a preflight expression representing that object.pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.