Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): making cron schedule more cloud agnostic (second attempt) #5956

Merged
merged 15 commits into from Mar 18, 2024

Conversation

marciocadev
Copy link
Collaborator

@marciocadev marciocadev commented Mar 16, 2024

Some characters like ? are configurations used by AWS, but to make the schedule more cloud-agnostic, I made some changes to bring it closer to the Unix implementation

Now a cron like * * * * * will not throw an exception.

I removed this test because it no longer made sense.

try {
      new cloud.Schedule( cron: "* * * * *" ) as "s5";
} catch e {
      error = e;
}
assert(error == "cannot use * in both the Day-of-month and Day-of-week fields. If you use it in one, you must use ? in the other");

Closes #2849

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@marciocadev marciocadev requested a review from a team as a code owner March 16, 2024 13:36
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

Copy link
Contributor

mergify bot commented Mar 18, 2024

Thanks for contributing, @marciocadev! This PR will now be added to the merge queue, or immediately merged if removing-question-mark-schedule is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Mar 18, 2024
@mergify mergify bot merged commit 7e544e2 into winglang:main Mar 18, 2024
15 checks passed
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.61.14.

@marciocadev marciocadev deleted the removing-question-mark-schedule branch March 23, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule fails to compile when using cron: "* * * * *"
4 participants