New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): making cron schedule more cloud agnostic (second attempt) #5956
fix(sdk): making cron schedule more cloud agnostic (second attempt) #5956
Conversation
Signed-off-by: monada-bot[bot] <monabot@monada.co>
…/wing into removing-question-mark-schedule
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Co-authored-by: Chris Rybicki <crybicki98@gmail.com>
Thanks for opening this pull request! 🎉
|
Thanks for contributing, @marciocadev! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.61.14. |
Some characters like
?
are configurations used by AWS, but to make the schedule more cloud-agnostic, I made some changes to bring it closer to the Unix implementationNow a cron like
* * * * *
will not throw an exception.I removed this test because it no longer made sense.
Closes #2849
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.