Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add line numbering to playground #928

Merged
merged 8 commits into from
Jan 19, 2023
Merged

Conversation

ogre14t
Copy link
Collaborator

@ogre14t ogre14t commented Dec 19, 2022

Closes #911
By submitting this pull request, I confirm that my contribution is made under the terms of the
Monada Contribution License
.

@ogre14t ogre14t requested a review from a team as a code owner December 19, 2022 23:00
@ogre14t ogre14t changed the title feat(playground): added line numbering. feat(examples): added line numbering. Dec 19, 2022
@staycoolcall911 staycoolcall911 changed the title feat(examples): added line numbering. feat(examples): added line numbering Dec 20, 2022
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! This will be super helpful for reading compiler error output 😁

apps/wing-playground/index.html Outdated Show resolved Hide resolved
apps/wing-playground/index.html Outdated Show resolved Hide resolved
apps/wing-playground/index.html Outdated Show resolved Hide resolved
apps/wing-playground/index.html Outdated Show resolved Hide resolved
apps/wing-playground/index.html Outdated Show resolved Hide resolved
apps/wing-playground/index.html Show resolved Hide resolved
@MarkMcCulloh MarkMcCulloh changed the title feat(examples): added line numbering fix: add line numbering to playground Dec 20, 2022
@eladb
Copy link
Contributor

eladb commented Jan 1, 2023

@ogre14t let us know if you need any help getting this across the finish line 🙏

@ogre14t
Copy link
Collaborator Author

ogre14t commented Jan 6, 2023

@ogre14t let us know if you need any help getting this across the finish line pray

Apologies, was on vacation. Will jump on this shortly.

@ogre14t
Copy link
Collaborator Author

ogre14t commented Jan 17, 2023

All suggested changes have been applied.

Copy link
Contributor

@MarkMcCulloh MarkMcCulloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

@staycoolcall911
Copy link
Contributor

Nice one @ogre14t ! Congrats!

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9041ce1 into main Jan 19, 2023
@mergify mergify bot deleted the ogre14t/playground_line_num branch January 19, 2023 22:02
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.4.111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wing Playground: add line numbers
5 participants