Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring slack #229

Merged
merged 20 commits into from
May 23, 2024
Merged

feat: bring slack #229

merged 20 commits into from
May 23, 2024

Conversation

hasanaburayyan
Copy link
Contributor

No description provided.

slack/README.md Outdated Show resolved Hide resolved
slack/README.md Show resolved Hide resolved
slack/README.md Outdated Show resolved Hide resolved
slack/README.md Show resolved Hide resolved
slack/README.md Show resolved Hide resolved
slack/events.w Outdated Show resolved Hide resolved
slack/events.w Show resolved Hide resolved
slack/lib.w Outdated Show resolved Hide resolved
slack/lib.w Outdated Show resolved Hide resolved
slack/lib.w Show resolved Hide resolved
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests...

I think this library needs some special behavior when running inside a test. Maybe some kind of mocking capabilities like we implemented for Bedrock

slack/README.md Outdated Show resolved Hide resolved
slack/lib.w Outdated Show resolved Hide resolved
slack/lib.w Outdated Show resolved Hide resolved
slack/lib.w Outdated Show resolved Hide resolved
slack/lib.w Outdated Show resolved Hide resolved
slack/message.w Show resolved Hide resolved
slack/message.w Outdated Show resolved Hide resolved
slack/message.w Outdated Show resolved Hide resolved
slack/package.json Show resolved Hide resolved
slack/util.w Outdated Show resolved Hide resolved
@hasanaburayyan hasanaburayyan marked this pull request as ready for review May 14, 2024 15:21
@hasanaburayyan hasanaburayyan requested review from eladb and a team May 14, 2024 16:19
@hasanaburayyan
Copy link
Contributor Author

Ah shit, I forgot tests... adding...

slack/README.md Outdated Show resolved Hide resolved
slack/README.md Outdated Show resolved Hide resolved
slack/events.w Outdated Show resolved Hide resolved
slack/lib.w Outdated Show resolved Hide resolved
slack/lib.w Outdated Show resolved Hide resolved
hasanaburayyan and others added 3 commits May 21, 2024 20:16
Co-authored-by: Chris Rybicki <chrisr@monada.co>
Co-authored-by: Chris Rybicki <chrisr@monada.co>
slack/README.md Show resolved Hide resolved
slack/README.md Show resolved Hide resolved
slack/README.md Show resolved Hide resolved
slack/README.md Show resolved Hide resolved
slack/README.md Outdated Show resolved Hide resolved
slack/context.w Outdated Show resolved Hide resolved
slack/context.w Outdated Show resolved Hide resolved
slack/context.w Outdated Show resolved Hide resolved
slack/lib.test.w Show resolved Hide resolved
Copy link

mergify bot commented May 23, 2024

Thank you for contributing! Your pull request contains mergify configuration changes and needs manual merge from a maintainer (be sure to allow changes to be pushed to your fork).

@hasanaburayyan hasanaburayyan merged commit 58b6dea into main May 23, 2024
5 checks passed
@hasanaburayyan hasanaburayyan deleted the hasan/slackbot branch May 23, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants