New API

[hebime]

This majorly overhauls Serum's API.
It allows you to provide options to initialize serum in a declarative way.

It adds a new source FromEnv which allows Serum to read existing environment variables and decrypt any if necessary.

[amineck]

I thought we agreed to have the from as a required param NewInjector(from fInterface, options ...Option). otherwise the API is bit confusing and error prone

[hebime]

Oh, I must have misunderstood. That works too. I currently have them as Options. I could make a separate type for the source.

[hebime]

Updated! The first param now is an interface called a Loader. It's responsible for loading env vars from an arbitrary source.

[iToto]

LGTM

[amineck]

Great job Rob!
Beside the defer ij.SecretProvider.Close() I think we have a great api now.

[hebime]

Great job Rob!
Beside the defer ij.SecretProvider.Close() I think we have a great api now.

Yea I don't like that either. We can move into the inject but then the user loses control. Either way, we can move this later.

[amineck]

sounds good 🙌
we can also do that by having https://github.com/wingocard/serum/blob/master/serum.go#L15 be a func() secretprovider.SecretProvider instead of secretprovider.SecretProvider.
or simpler, create an ij.Close() that closes all underlying connections.