Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware update #15

Merged
merged 6 commits into from
Feb 19, 2021
Merged

Middleware update #15

merged 6 commits into from
Feb 19, 2021

Conversation

hebime
Copy link
Contributor

@hebime hebime commented Feb 19, 2021

This changes the WithSecretProvider middleware to accept a function. This gives the dev more control over how the SecretProvider gets initialized.

A Close method has been added ton the Injector as suggested in #14

The SecretProvider on the Injector has been unexported.

@hebime hebime requested review from amineck and iToto February 19, 2021 00:56
Copy link
Contributor

@amineck amineck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hebime hebime merged commit f39a288 into master Feb 19, 2021
@hebime hebime deleted the middleware-update branch February 19, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants