Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update protobuf-c to version 1.5.0" #1173

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

AlessandroBono
Copy link
Contributor

Like 457db7c, now also protobuf-c requires abseil-cpp as a dependency[1]:

Building project protobuf-c (1.5.0)
Generating/updating cmake files
Debug: running cmake -G "Ninja"
[...]
-- Found Protobuf: C:/build/gtk/x64/debug/lib/libprotobuf.lib (found version "3.21.12")
-- Could NOT find absl (missing: absl_DIR)
-- Configuring incomplete, errors occurred!

Revert to the previous version for now.

This reverts commit a91cadd.

[1] protobuf-c/protobuf-c@5db0ca5

Like 457db7c, now also protobuf-c
requires abseil-cpp as a dependency[1]:
```
Building project protobuf-c (1.5.0)
Generating/updating cmake files
Debug: running cmake -G "Ninja"
[...]
-- Found Protobuf: C:/build/gtk/x64/debug/lib/libprotobuf.lib (found version "3.21.12")
-- Could NOT find absl (missing: absl_DIR)
-- Configuring incomplete, errors occurred!
```

Revert to the previous version for now.

This reverts commit a91cadd.

[1] protobuf-c/protobuf-c@5db0ca5
@nacho
Copy link
Contributor

nacho commented Dec 13, 2023

Maybe open an issue to add absl

@AlessandroBono
Copy link
Contributor Author

AlessandroBono commented Dec 13, 2023

Maybe open an issue to add absl

Done #1174

@nacho nacho merged commit ed01590 into wingtk:main Dec 13, 2023
12 checks passed
@nacho
Copy link
Contributor

nacho commented Dec 13, 2023

Thanks

@danyeaw
Copy link
Member

danyeaw commented Dec 13, 2023

Thanks @AlessandroBono, forgot I was working on getting abseil to build

@AlessandroBono
Copy link
Contributor Author

Hey @danyeaw, I worked on this today. I didn't notice #941, sorry. I opened #1175 that successfully builds protobuf 25.1. However, protobuf-c 1.5.0 still fails.

@AlessandroBono AlessandroBono deleted the wip/abono/revert-protobuf branch February 12, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants