Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Protobuf general update #1175

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AlessandroBono
Copy link
Contributor

Marked as Draft since the build of protobuf-c 1.5.0 still fails. See protobuf-c/protobuf-c#698

@AlessandroBono
Copy link
Contributor Author

I worked around the issue about the missing Config.cmake.in file by including it here. However the compilation via cmake still fails.

@AlessandroBono
Copy link
Contributor Author

The compilation is failing due to protobuf-c/protobuf-c#699

@nacho
Copy link
Contributor

nacho commented Dec 18, 2023

@AlessandroBono is this ready?

@AlessandroBono AlessandroBono force-pushed the wip/abono/protobuf branch 2 times, most recently from 2cb6fe1 to 3a29d2b Compare December 18, 2023 13:19
Add abseil-cpp as a dependency. It is required since version 22.0 (aka 3.22.0)[1]

[1] protocolbuffers/protobuf@a9f1ea6
Add abseil-cpp as a dependency since it is now required. Furthermore:
 - add Config.cmake.in file[1] because it is missing from the tarball;
 - add a proposed patch[2] to fix the build with cmake.

[1] protobuf-c/protobuf-c#698
[2] protobuf-c/protobuf-c#699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants