Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: update to version 3.2.1 #1226

Merged
merged 2 commits into from
Feb 12, 2024
Merged

openssl: update to version 3.2.1 #1226

merged 2 commits into from
Feb 12, 2024

Conversation

nacho
Copy link
Contributor

@nacho nacho commented Jan 31, 2024

No description provided.

@danyeaw danyeaw requested review from danyeaw and pbor February 10, 2024 18:20
Copy link
Contributor

@pbor pbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave review to nacho/alessandro for the openssl stuff

@nacho
Copy link
Contributor Author

nacho commented Feb 12, 2024

It seems that I can not approve it :( Thanks for fixing the patch! Any idea if this is something we should report upstream? @pbor can you merge it?

Copy link
Contributor

@pbor pbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving as suggested by Nacho.

It is unclear to me how these updates impact the FIPS part

@danyeaw
Copy link
Member

danyeaw commented Feb 12, 2024

I took the patch from upstream, the link to the commit is in my commit message.

@nacho
Copy link
Contributor Author

nacho commented Feb 12, 2024

There is no other FIPs release so I think we are good to merge this now.

@nacho nacho merged commit 08f78c6 into main Feb 12, 2024
12 checks passed
@nacho nacho deleted the wip/nacho/openssl-3.2.1 branch February 12, 2024 11:08
@nacho
Copy link
Contributor Author

nacho commented Feb 12, 2024

One note about this, we tested glib-networking with openssl 3.2 and there was some regression which we do not know if it will affect also Windows. Just a note that we might need to revert this if it also happens for windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants