always define version in projects #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbor
reviewed
Nov 16, 2022
| @@ -27,7 +27,8 @@ def __init__(self): | |||
| Project.__init__( | |||
| self, | |||
| "adwaita-icon-theme", | |||
| archive_url="https://download.gnome.org/sources/adwaita-icon-theme/43/adwaita-icon-theme-43.tar.xz", | |||
| version="43", | |||
| archive_url="https://download.gnome.org/sources/adwaita-icon-theme/{version}/adwaita-icon-theme-43.tar.xz", | |||
There was a problem hiding this comment.
I guess {version} also in the name
saste
force-pushed
the
wip/review-versioning
branch
3 times, most recently
from
e25791c
to
2a4c44f
Compare
Always define version in projects, use the version to compute the file archive name. Increase accuracy of the computed version, since it cannot be always be computed from the archive name, while it's always possible to use the version information to define the archive name/url.
saste
force-pushed
the
wip/review-versioning
branch
from
2a4c44f
to
2b30391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always define version in projects, use the version to compute the file archive name. Increase reliability of the version computation, since it cannot be always be computed from the archive name (is much simpler to do the opposite).